Skip to content

Commit db4a568

Browse files
committed
Cleanup
1 parent 505ba1d commit db4a568

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

common/src/main/kotlin/com/lambda/task/Task.kt

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -313,11 +313,14 @@ abstract class Task<Result> : Nameable, Muteable {
313313
override fun toString() =
314314
buildString { appendTaskTree(this@Task) }
315315

316-
private fun StringBuilder.appendTaskTree(task: Task<*>, level: Int = 0) {
316+
private fun StringBuilder.appendTaskTree(task: Task<*>, level: Int = 0, maxEntries: Int = 10) {
317+
if (task.state == State.CANCELLED) return
317318
appendLine("${" ".repeat(level * 4)}${task.name}" + if (task !is RootTask) " [${task.state.display}] ${task.duration}" else "")
318-
if (!TaskFlowModule.showAllEntries && (task.state == State.COMPLETED || task.state == State.CANCELLED)) return
319-
task.subTasks.forEach {
320-
if (!TaskFlowModule.showAllEntries && task is RootTask && (it.state == State.COMPLETED || it.state == State.CANCELLED)) return@forEach
319+
val left = task.subTasks.size - maxEntries
320+
if (left > 0) {
321+
appendLine("${" ".repeat(level * 5)}...and $left more tasks")
322+
}
323+
task.subTasks.takeLast(maxEntries).forEach {
321324
appendTaskTree(it, level + 1)
322325
}
323326
}

common/src/main/kotlin/com/lambda/task/tasks/BuildTask.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,6 @@ class BuildTask @Ta5kBuilder constructor(
120120
val resultsWithoutPending = results.filterNot { result ->
121121
result.blockPos in pendingInteractions.map { it.expectedPos }
122122
}
123-
val sortedResults = resultsWithoutPending.sorted()
124-
sortedResults
125123
val bestResult = resultsWithoutPending.minOrNull() ?: return@listen
126124
when (bestResult) {
127125
is BuildResult.Done,
@@ -172,7 +170,7 @@ class BuildTask @Ta5kBuilder constructor(
172170
is Resolvable -> {
173171
LOG.info("Resolving: ${bestResult.name}")
174172

175-
bestResult.resolve().execute(this@BuildTask, pauseParent = true)
173+
bestResult.resolve().execute(this@BuildTask)
176174
}
177175
}
178176
}

0 commit comments

Comments
 (0)