LEVM: Change name when popping call_frame to something more descriptive #2569
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
May 12, 2025
…2730) **Motivation** Give a better description of call_frame related variables in run_execution(). **Description** - Use `executed_call_frame` in scenarios in which the callframe has already been executed. - Use `parent_call_frame` in scenarios in which a callframe has been popped before, to we are working with the previous one. <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #2569
fmoletta
pushed a commit
that referenced
this issue
May 15, 2025
…2730) **Motivation** Give a better description of call_frame related variables in run_execution(). **Description** - Use `executed_call_frame` in scenarios in which the callframe has already been executed. - Use `parent_call_frame` in scenarios in which a callframe has been popped before, to we are working with the previous one. <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #2569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After #2417 is merged
In run_execution of LEVM when we pop a callframe for handling the execution result the name of
call_frameisn't very descriptive neither there nor inside the functions that take callframe as parameter.I think that maybe
executed_call_framewould be a more reasonable name. And also, the current callframe in that context could be calledparent_call_frame(or not,current_call_frameis good enough I'd say).The text was updated successfully, but these errors were encountered: