feat(l2): verify batches in chunks with aligned #3242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_use_hardcoded_vk
…d_use_hardcoded_vk
…d_use_hardcoded_vk
> [!WARNING] > Merge after #3242 **Motivation** In case one RPC or Beacon client fails, we should retry with others to avoid getting stuck. **Description** - Implements a wrapper over `aligned_sdk::estimate_fee()` to retry using all available RPC urls. - Implements a wrapper over `aligned_sdk::check_proof_verification()` to retry using all available RPC and Beacon clients. Closes #3059
MegaRedHand
reviewed
Jun 27, 2025
Contributor
ManuelBilbao
left a comment
ManuelBilbao
left a comment
There was a problem hiding this comment.
Looks good, just some little comments
Comment on lines
183
to
194
| loop { | ||
| if !batch_number_has_all_needed_proofs(batch_number, &[ProverType::Aligned]) | ||
| .is_ok_and(|has_all_proofs| has_all_proofs) | ||
| { | ||
| return Ok(proofs); | ||
| } | ||
| proofs.push(( | ||
| batch_number, | ||
| read_proof(batch_number, StateFileType::BatchProof(ProverType::Aligned))?, | ||
| )); | ||
| batch_number += 1; | ||
| } |
Contributor
There was a problem hiding this comment.
Nit
Suggested change
| loop { | |
| if !batch_number_has_all_needed_proofs(batch_number, &[ProverType::Aligned]) | |
| .is_ok_and(|has_all_proofs| has_all_proofs) | |
| { | |
| return Ok(proofs); | |
| } | |
| proofs.push(( | |
| batch_number, | |
| read_proof(batch_number, StateFileType::BatchProof(ProverType::Aligned))?, | |
| )); | |
| batch_number += 1; | |
| } | |
| while !batch_number_has_all_needed_proofs(batch_number, &[ProverType::Aligned]) | |
| .is_ok_and(|has_all_proofs| has_all_proofs) { | |
| proofs.push(( | |
| batch_number, | |
| read_proof(batch_number, StateFileType::BatchProof(ProverType::Aligned))?, | |
| )); | |
| batch_number += 1; | |
| } |
Contributor
There was a problem hiding this comment.
Do we need to update this functions too as in non-based ones?
ManuelBilbao
approved these changes
Jun 30, 2025
MegaRedHand
approved these changes
Jun 30, 2025
Comment on lines
333
to
336
| require( | ||
| batchNumber == lastVerifiedBatch + 1, | ||
| "OnChainProposer: incorrect batch number" | ||
| ); |
Collaborator
There was a problem hiding this comment.
This can be checked just for firstBatchNumber outside the loop.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 30, 2025
**Motivation** In #3242, `verifyBatchesAligned()` was updated in the based `OnChainProposer` to be consistent with the non-based one, but the `onlySequencer` identifier was added by mistake. **Description** Removes the `onlySequencer` identifier. Closes None
avilagaston9
added a commit
that referenced
this pull request
Jun 30, 2025
**Motivation** In #3242, `verifyBatchesAligned()` was updated in the based `OnChainProposer` to be consistent with the non-based one, but the `onlySequencer` identifier was added by mistake. **Description** Removes the `onlySequencer` identifier. Closes None
d-roak
pushed a commit
to 1sixtech/ethrex
that referenced
this pull request
Jul 17, 2025
**Motivation** Aligned verifies proofs in batches, so it's possible to have an array of proofs ready to be verified at once. **Description** - Modifies `l1_proof_verifier` to check all already aggregated proofs and build a single verify transaction for them. - Updates `verifyBatchAligned()` in the `OnChainProposer` contract to accept an array of proofs. > [!WARNING] > lambdaclass#3276 was accidentally merged into this PR, so the diff includes changes from both. Closes lambdaclass#3168 --------- Co-authored-by: Ivan Litteri <[email protected]>
d-roak
pushed a commit
to 1sixtech/ethrex
that referenced
this pull request
Jul 17, 2025
**Motivation** In lambdaclass#3242, `verifyBatchesAligned()` was updated in the based `OnChainProposer` to be consistent with the non-based one, but the `onlySequencer` identifier was added by mistake. **Description** Removes the `onlySequencer` identifier. Closes None
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** Aligned verifies proofs in batches, so it's possible to have an array of proofs ready to be verified at once. **Description** - Modifies `l1_proof_verifier` to check all already aggregated proofs and build a single verify transaction for them. - Updates `verifyBatchAligned()` in the `OnChainProposer` contract to accept an array of proofs. > [!WARNING] > lambdaclass#3276 was accidentally merged into this PR, so the diff includes changes from both. Closes lambdaclass#3168 --------- Co-authored-by: Ivan Litteri <[email protected]>
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** In lambdaclass#3242, `verifyBatchesAligned()` was updated in the based `OnChainProposer` to be consistent with the non-based one, but the `onlySequencer` identifier was added by mistake. **Description** Removes the `onlySequencer` identifier. Closes None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Aligned verifies proofs in batches, so it's possible to have an array of proofs ready to be verified at once.
Description
l1_proof_verifierto check all already aggregated proofs and build a single verify transaction for them.verifyBatchAligned()in theOnChainProposercontract to accept an array of proofs.Warning
#3276 was accidentally merged into this PR, so the diff includes changes from both.
Closes #3168