Remove allow_materialized_view_with_bad_select from ClickHouse users.xml (incompatible with ClickHouse ≥ 24.8) #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xml (incompatible with ClickHouse ≥ 24.8) This patch removes the <allow_materialized_view_with_bad_select> setting from the default ClickHouse users.xml configuration included in the charts/langsmith/docker-compose setup. The allow_materialized_view_with_bad_select setting is no longer supported in ClickHouse 24.8 and causes startup failures (error UNKNOWN_SETTING) when the chart is used with newer ClickHouse versions. Backward compatibility note: If users rely on that setting in older versions, they may manually reintroduce the setting in a custom override (if still supported), but this is not recommended. Changes in this PR: - Removed the <allow_materialized_view_with_bad_select> line from the default users.xml template. Testing: - Verified that when deploying with ClickHouse 24.8+, ClickHouse now starts successfully and LangSmith operates normally. Related issue / justification: - This addresses the startup error that arises due to unknown setting in ClickHouse. - Users have reported this issue when upgrading. Please let me know if you’d like a version-guard or conditional logic instead of outright removal, but upstream compatibility strongly suggests the removal is safer long-term.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the <allow_materialized_view_with_bad_select> setting from the default ClickHouse users.xml configuration included in the charts/langsmith/docker-compose setup.
The allow_materialized_view_with_bad_select setting is no longer supported in ClickHouse 24.8 and causes startup failures (error UNKNOWN_SETTING) when the chart is used with newer ClickHouse versions.
Backward compatibility note: If users rely on that setting in older versions, they may manually reintroduce the setting in a custom override (if still supported), but this is not recommended.
Changes in this PR:
Testing:
Related issue / justification:
This addresses the startup error that arises due to unknown setting in ClickHouse.
Users have reported this issue when upgrading.
Please let me know if you’d like a version-guard or conditional logic instead of outright removal, but upstream compatibility strongly suggests the removal is safer long-term.