langchain: use mypy strict checking with exemptions (#31018)

cbornet · eyurtsev · web-flow · commit 6cd1aadf60c9 · 2025-05-15T11:37:18.000-04:00
* Use strict checking and exclude some rules as TODOs
* Fix imports not exposed in `__all__`

Co-authored-by: Eugene Yurtsev &lt;eyurtsev@gmail.com&gt;
diff --git a/libs/langchain/langchain/agents/initialize.py b/libs/langchain/langchain/agents/initialize.py
@@ -11,7 +11,8 @@
 from langchain._api.deprecation import AGENT_DEPRECATION_WARNING
 from langchain.agents.agent import AgentExecutor
 from langchain.agents.agent_types import AgentType
-from langchain.agents.loading import AGENT_TO_CLASS, load_agent
+from langchain.agents.loading import load_agent
+from langchain.agents.types import AGENT_TO_CLASS
 
 
 @deprecated(
diff --git a/libs/langchain/langchain/agents/openai_functions_agent/base.py b/libs/langchain/langchain/agents/openai_functions_agent/base.py
@@ -13,11 +13,11 @@
 )
 from langchain_core.prompts import BasePromptTemplate
 from langchain_core.prompts.chat import (
-    BaseMessagePromptTemplate,
     ChatPromptTemplate,
     HumanMessagePromptTemplate,
     MessagesPlaceholder,
 )
+from langchain_core.prompts.message import BaseMessagePromptTemplate
 from langchain_core.runnables import Runnable, RunnablePassthrough
 from langchain_core.tools import BaseTool
 from langchain_core.utils.function_calling import convert_to_openai_function
diff --git a/libs/langchain/langchain/agents/openai_functions_multi_agent/base.py b/libs/langchain/langchain/agents/openai_functions_multi_agent/base.py
@@ -17,11 +17,11 @@
 )
 from langchain_core.prompts import BasePromptTemplate
 from langchain_core.prompts.chat import (
-    BaseMessagePromptTemplate,
     ChatPromptTemplate,
     HumanMessagePromptTemplate,
     MessagesPlaceholder,
 )
+from langchain_core.prompts.message import BaseMessagePromptTemplate
 from langchain_core.tools import BaseTool
 from pydantic import model_validator
 from typing_extensions import Self
diff --git a/libs/langchain/langchain/agents/output_parsers/json.py b/libs/langchain/langchain/agents/output_parsers/json.py
@@ -5,7 +5,7 @@
 
 from langchain_core.agents import AgentAction, AgentFinish
 from langchain_core.exceptions import OutputParserException
-from langchain_core.output_parsers.json import parse_json_markdown
+from langchain_core.utils.json import parse_json_markdown
 
 from langchain.agents.agent import AgentOutputParser
 
diff --git a/libs/langchain/langchain/callbacks/manager.py b/libs/langchain/langchain/callbacks/manager.py
@@ -2,6 +2,7 @@
 
 from typing import TYPE_CHECKING, Any
 
+from langchain_core.callbacks import Callbacks
 from langchain_core.callbacks.manager import (
     AsyncCallbackManager,
     AsyncCallbackManagerForChainGroup,
@@ -18,7 +19,6 @@
     CallbackManagerForLLMRun,
     CallbackManagerForRetrieverRun,
     CallbackManagerForToolRun,
-    Callbacks,
     ParentRunManager,
     RunManager,
     ahandle_event,
diff --git a/libs/langchain/langchain/callbacks/tracers/base.py b/libs/langchain/langchain/callbacks/tracers/base.py
@@ -1,5 +1,6 @@
 """Base interfaces for tracing runs."""
 
-from langchain_core.tracers.base import BaseTracer, TracerException
+from langchain_core.exceptions import TracerException
+from langchain_core.tracers.base import BaseTracer
 
 __all__ = ["BaseTracer", "TracerException"]
diff --git a/libs/langchain/langchain/chains/base.py b/libs/langchain/langchain/chains/base.py
@@ -27,7 +27,7 @@
     ensure_config,
     run_in_executor,
 )
-from langchain_core.runnables.utils import create_model
+from langchain_core.utils.pydantic import create_model
 from pydantic import (
     BaseModel,
     ConfigDict,
diff --git a/libs/langchain/langchain/chains/combine_documents/base.py b/libs/langchain/langchain/chains/combine_documents/base.py
@@ -11,7 +11,7 @@
 from langchain_core.documents import Document
 from langchain_core.prompts import BasePromptTemplate, PromptTemplate
 from langchain_core.runnables.config import RunnableConfig
-from langchain_core.runnables.utils import create_model
+from langchain_core.utils.pydantic import create_model
 from langchain_text_splitters import RecursiveCharacterTextSplitter, TextSplitter
 from pydantic import BaseModel, Field
 
diff --git a/libs/langchain/langchain/chains/combine_documents/map_reduce.py b/libs/langchain/langchain/chains/combine_documents/map_reduce.py
@@ -8,7 +8,7 @@
 from langchain_core.callbacks import Callbacks
 from langchain_core.documents import Document
 from langchain_core.runnables.config import RunnableConfig
-from langchain_core.runnables.utils import create_model
+from langchain_core.utils.pydantic import create_model
 from pydantic import BaseModel, ConfigDict, model_validator
 
 from langchain.chains.combine_documents.base import BaseCombineDocumentsChain
diff --git a/libs/langchain/langchain/chains/combine_documents/map_rerank.py b/libs/langchain/langchain/chains/combine_documents/map_rerank.py
@@ -9,7 +9,7 @@
 from langchain_core.callbacks import Callbacks
 from langchain_core.documents import Document
 from langchain_core.runnables.config import RunnableConfig
-from langchain_core.runnables.utils import create_model
+from langchain_core.utils.pydantic import create_model
 from pydantic import BaseModel, ConfigDict, model_validator
 from typing_extensions import Self
 
diff --git a/libs/langchain/langchain/evaluation/agents/trajectory_eval_chain.py b/libs/langchain/langchain/evaluation/agents/trajectory_eval_chain.py
@@ -16,10 +16,10 @@
 )
 
 from langchain_core.agents import AgentAction
+from langchain_core.callbacks import Callbacks
 from langchain_core.callbacks.manager import (
     AsyncCallbackManagerForChainRun,
     CallbackManagerForChainRun,
-    Callbacks,
 )
 from langchain_core.exceptions import OutputParserException
 from langchain_core.language_models import BaseLanguageModel
diff --git a/libs/langchain/langchain/evaluation/comparison/eval_chain.py b/libs/langchain/langchain/evaluation/comparison/eval_chain.py
@@ -6,7 +6,7 @@
 import re
 from typing import Any, Optional, Union
 
-from langchain_core.callbacks.manager import Callbacks
+from langchain_core.callbacks import Callbacks
 from langchain_core.language_models import BaseLanguageModel
 from langchain_core.output_parsers import BaseOutputParser
 from langchain_core.prompts.prompt import PromptTemplate
diff --git a/libs/langchain/langchain/evaluation/criteria/eval_chain.py b/libs/langchain/langchain/evaluation/criteria/eval_chain.py
@@ -5,7 +5,7 @@
 from enum import Enum
 from typing import Any, Optional, Union
 
-from langchain_core.callbacks.manager import Callbacks
+from langchain_core.callbacks import Callbacks
 from langchain_core.language_models import BaseLanguageModel
 from langchain_core.output_parsers import BaseOutputParser
 from langchain_core.prompts import BasePromptTemplate
diff --git a/libs/langchain/langchain/evaluation/embedding_distance/base.py b/libs/langchain/langchain/evaluation/embedding_distance/base.py
@@ -6,10 +6,10 @@
 from importlib import util
 from typing import Any, Optional
 
+from langchain_core.callbacks import Callbacks
 from langchain_core.callbacks.manager import (
     AsyncCallbackManagerForChainRun,
     CallbackManagerForChainRun,
-    Callbacks,
 )
 from langchain_core.embeddings import Embeddings
 from langchain_core.utils import pre_init
diff --git a/libs/langchain/langchain/evaluation/qa/eval_chain.py b/libs/langchain/langchain/evaluation/qa/eval_chain.py
@@ -7,7 +7,7 @@
 from collections.abc import Sequence
 from typing import Any, Optional
 
-from langchain_core.callbacks.manager import Callbacks
+from langchain_core.callbacks import Callbacks
 from langchain_core.language_models import BaseLanguageModel
 from langchain_core.prompts import PromptTemplate
 from pydantic import ConfigDict
diff --git a/libs/langchain/langchain/evaluation/scoring/eval_chain.py b/libs/langchain/langchain/evaluation/scoring/eval_chain.py
@@ -6,7 +6,7 @@
 import re
 from typing import Any, Optional, Union
 
-from langchain_core.callbacks.manager import Callbacks
+from langchain_core.callbacks import Callbacks
 from langchain_core.language_models import BaseLanguageModel
 from langchain_core.output_parsers import BaseOutputParser
 from langchain_core.prompts.prompt import PromptTemplate
diff --git a/libs/langchain/langchain/evaluation/string_distance/base.py b/libs/langchain/langchain/evaluation/string_distance/base.py
@@ -3,10 +3,10 @@
 from enum import Enum
 from typing import Any, Callable, Optional
 
+from langchain_core.callbacks import Callbacks
 from langchain_core.callbacks.manager import (
     AsyncCallbackManagerForChainRun,
     CallbackManagerForChainRun,
-    Callbacks,
 )
 from langchain_core.utils import pre_init
 from pydantic import Field
diff --git a/libs/langchain/langchain/memory/buffer.py b/libs/langchain/langchain/memory/buffer.py
@@ -1,10 +1,11 @@
 from typing import Any, Optional
 
 from langchain_core._api import deprecated
+from langchain_core.memory import BaseMemory
 from langchain_core.messages import BaseMessage, get_buffer_string
 from langchain_core.utils import pre_init
 
-from langchain.memory.chat_memory import BaseChatMemory, BaseMemory
+from langchain.memory.chat_memory import BaseChatMemory
 from langchain.memory.utils import get_prompt_input_key
 
 
diff --git a/libs/langchain/langchain/memory/vectorstore.py b/libs/langchain/langchain/memory/vectorstore.py
@@ -5,10 +5,10 @@
 
 from langchain_core._api import deprecated
 from langchain_core.documents import Document
+from langchain_core.memory import BaseMemory
 from langchain_core.vectorstores import VectorStoreRetriever
 from pydantic import Field
 
-from langchain.memory.chat_memory import BaseMemory
 from langchain.memory.utils import get_prompt_input_key
 
 
diff --git a/libs/langchain/langchain/prompts/chat.py b/libs/langchain/langchain/prompts/chat.py
@@ -2,7 +2,6 @@
 from langchain_core.prompts.chat import (
     AIMessagePromptTemplate,
     BaseChatPromptTemplate,
-    BaseMessagePromptTemplate,
     BaseStringMessagePromptTemplate,
     ChatMessagePromptTemplate,
     ChatPromptTemplate,
@@ -34,3 +33,5 @@
     "MessageLike",
     "MessageLikeRepresentation",
 ]
+
+from langchain_core.prompts.message import BaseMessagePromptTemplate
diff --git a/libs/langchain/langchain/retrievers/contextual_compression.py b/libs/langchain/langchain/retrievers/contextual_compression.py
@@ -4,14 +4,10 @@
     AsyncCallbackManagerForRetrieverRun,
     CallbackManagerForRetrieverRun,
 )
-from langchain_core.documents import Document
+from langchain_core.documents import BaseDocumentCompressor, Document
 from langchain_core.retrievers import BaseRetriever, RetrieverLike
 from pydantic import ConfigDict
 
-from langchain.retrievers.document_compressors.base import (
-    BaseDocumentCompressor,
-)
-
 
 class ContextualCompressionRetriever(BaseRetriever):
     """Retriever that wraps a base retriever and compresses the results."""
diff --git a/libs/langchain/langchain/retrievers/document_compressors/__init__.py b/libs/langchain/langchain/retrievers/document_compressors/__init__.py
@@ -34,9 +34,10 @@ def __getattr__(name: str) -> Any:
 __all__ = [
     "DocumentCompressorPipeline",
     "EmbeddingsFilter",
+    "FlashrankRerank",
     "LLMListwiseRerank",
     "LLMChainExtractor",
     "LLMChainFilter",
     "CohereRerank",
     "CrossEncoderReranker",
-] + list(_module_lookup.keys())
+]
diff --git a/libs/langchain/langchain/retrievers/document_compressors/base.py b/libs/langchain/langchain/retrievers/document_compressors/base.py
@@ -2,7 +2,7 @@
 from inspect import signature
 from typing import Optional, Union
 
-from langchain_core.callbacks.manager import Callbacks
+from langchain_core.callbacks import Callbacks
 from langchain_core.documents import (
     BaseDocumentCompressor,
     BaseDocumentTransformer,
diff --git a/libs/langchain/langchain/retrievers/document_compressors/chain_extract.py b/libs/langchain/langchain/retrievers/document_compressors/chain_extract.py
@@ -5,16 +5,15 @@
 from collections.abc import Sequence
 from typing import Any, Callable, Optional, cast
 
-from langchain_core.callbacks.manager import Callbacks
-from langchain_core.documents import Document
+from langchain_core.callbacks import Callbacks
+from langchain_core.documents import BaseDocumentCompressor, Document
 from langchain_core.language_models import BaseLanguageModel
 from langchain_core.output_parsers import BaseOutputParser, StrOutputParser
 from langchain_core.prompts import PromptTemplate
 from langchain_core.runnables import Runnable
 from pydantic import ConfigDict
 
 from langchain.chains.llm import LLMChain
-from langchain.retrievers.document_compressors.base import BaseDocumentCompressor
 from langchain.retrievers.document_compressors.chain_extract_prompt import (
     prompt_template,
 )
diff --git a/libs/langchain/langchain/retrievers/document_compressors/chain_filter.py b/libs/langchain/langchain/retrievers/document_compressors/chain_filter.py
@@ -3,8 +3,8 @@
 from collections.abc import Sequence
 from typing import Any, Callable, Optional
 
-from langchain_core.callbacks.manager import Callbacks
-from langchain_core.documents import Document
+from langchain_core.callbacks import Callbacks
+from langchain_core.documents import BaseDocumentCompressor, Document
 from langchain_core.language_models import BaseLanguageModel
 from langchain_core.output_parsers import StrOutputParser
 from langchain_core.prompts import BasePromptTemplate, PromptTemplate
@@ -14,7 +14,6 @@
 
 from langchain.chains import LLMChain
 from langchain.output_parsers.boolean import BooleanOutputParser
-from langchain.retrievers.document_compressors.base import BaseDocumentCompressor
 from langchain.retrievers.document_compressors.chain_filter_prompt import (
     prompt_template,
 )
diff --git a/libs/langchain/langchain/retrievers/document_compressors/cohere_rerank.py b/libs/langchain/langchain/retrievers/document_compressors/cohere_rerank.py
@@ -5,13 +5,11 @@
 from typing import Any, Optional, Union
 
 from langchain_core._api.deprecation import deprecated
-from langchain_core.callbacks.manager import Callbacks
-from langchain_core.documents import Document
+from langchain_core.callbacks import Callbacks
+from langchain_core.documents import BaseDocumentCompressor, Document
 from langchain_core.utils import get_from_dict_or_env
 from pydantic import ConfigDict, model_validator
 
-from langchain.retrievers.document_compressors.base import BaseDocumentCompressor
-
 
 @deprecated(
     since="0.0.30", removal="1.0", alternative_import="langchain_cohere.CohereRerank"
diff --git a/libs/langchain/langchain/retrievers/document_compressors/embeddings_filter.py b/libs/langchain/langchain/retrievers/document_compressors/embeddings_filter.py
@@ -1,16 +1,12 @@
 from collections.abc import Sequence
 from typing import Callable, Optional
 
-from langchain_core.callbacks.manager import Callbacks
-from langchain_core.documents import Document
+from langchain_core.callbacks import Callbacks
+from langchain_core.documents import BaseDocumentCompressor, Document
 from langchain_core.embeddings import Embeddings
 from langchain_core.utils import pre_init
 from pydantic import ConfigDict, Field
 
-from langchain.retrievers.document_compressors.base import (
-    BaseDocumentCompressor,
-)
-
 
 def _get_similarity_function() -> Callable:
     try:
diff --git a/libs/langchain/langchain/runnables/hub.py b/libs/langchain/langchain/runnables/hub.py
@@ -1,6 +1,7 @@
 from typing import Any, Optional
 
-from langchain_core.runnables.base import Input, Output, RunnableBindingBase
+from langchain_core.runnables.base import RunnableBindingBase
+from langchain_core.runnables.utils import Input, Output
 
 
 class HubRunnable(RunnableBindingBase[Input, Output]):
diff --git a/libs/langchain/langchain/schema/callbacks/tracers/base.py b/libs/langchain/langchain/schema/callbacks/tracers/base.py
@@ -1,3 +1,4 @@
-from langchain_core.tracers.base import BaseTracer, TracerException
+from langchain_core.exceptions import TracerException
+from langchain_core.tracers.base import BaseTracer
 
 __all__ = ["TracerException", "BaseTracer"]
diff --git a/libs/langchain/langchain/smith/evaluation/runner_utils.py b/libs/langchain/langchain/smith/evaluation/runner_utils.py
@@ -19,7 +19,7 @@
 )
 
 from langchain_core._api import warn_deprecated
-from langchain_core.callbacks.manager import Callbacks
+from langchain_core.callbacks import Callbacks
 from langchain_core.language_models import BaseLanguageModel
 from langchain_core.messages import BaseMessage, messages_from_dict
 from langchain_core.outputs import ChatResult, LLMResult
@@ -1226,7 +1226,7 @@ def prepare(
 
 def _is_jupyter_environment() -> bool:
     try:
-        from IPython import get_ipython
+        from IPython.core.getipython import get_ipython
 
         res = get_ipython()
         return get_ipython() is not None and "zmqshell" in str(type(res))
diff --git a/libs/langchain/pyproject.toml b/libs/langchain/pyproject.toml
@@ -91,7 +91,7 @@ lint = [
     "cffi; python_version >= \"3.10\"",
 ]
 typing = [
-    "mypy<2.0,>=1.15",
+    "mypy<1.16,>=1.15",
     "types-pyyaml<7.0.0.0,>=6.0.12.2",
     "types-requests<3.0.0.0,>=2.28.11.5",
     "types-toml<1.0.0.0,>=0.10.8.1",
@@ -124,9 +124,18 @@ target-version = "py39"
 exclude = ["tests/integration_tests/examples/non-utf8-encoding.py"]
 
 [tool.mypy]
+strict = "True"
+strict_bytes = "True"
 ignore_missing_imports = "True"
-disallow_untyped_defs = "True"
-warn_unused_ignores = "True"
+enable_error_code = "deprecated"
+report_deprecated_as_note = "True"
+
+# TODO: activate for 'strict' checking
+disallow_untyped_calls = "False"
+disallow_any_generics = "False"
+disallow_untyped_decorators = "False"
+warn_return_any = "False"
+strict_equality = "False"
 
 [tool.codespell]
 skip = ".git,*.pdf,*.svg,*.pdf,*.yaml,*.ipynb,poetry.lock,*.min.js,*.css,package-lock.json,example_data,_dist,examples,*.trig"
diff --git a/libs/langchain/tests/unit_tests/callbacks/test_file.py b/libs/langchain/tests/unit_tests/callbacks/test_file.py
diff --git a/libs/langchain/tests/unit_tests/callbacks/test_stdout.py b/libs/langchain/tests/unit_tests/callbacks/test_stdout.py
diff --git a/libs/langchain/tests/unit_tests/evaluation/agents/test_eval_chain.py b/libs/langchain/tests/unit_tests/evaluation/agents/test_eval_chain.py
diff --git a/libs/langchain/tests/unit_tests/output_parsers/test_fix.py b/libs/langchain/tests/unit_tests/output_parsers/test_fix.py
diff --git a/libs/langchain/tests/unit_tests/output_parsers/test_retry.py b/libs/langchain/tests/unit_tests/output_parsers/test_retry.py
diff --git a/libs/langchain/tests/unit_tests/retrievers/sequential_retriever.py b/libs/langchain/tests/unit_tests/retrievers/sequential_retriever.py
diff --git a/libs/langchain/tests/unit_tests/runnables/test_hub.py b/libs/langchain/tests/unit_tests/runnables/test_hub.py
diff --git a/libs/langchain/tests/unit_tests/runnables/test_openai_functions.py b/libs/langchain/tests/unit_tests/runnables/test_openai_functions.py
diff --git a/libs/langchain/uv.lock b/libs/langchain/uv.lock

Original file line number	Diff line number	Diff line change
`@@ -13,11 +13,11 @@`
`13`	`13`	`)`
`14`	`14`	`from langchain_core.prompts import BasePromptTemplate`
`15`	`15`	`from langchain_core.prompts.chat import (`
`16`		`- BaseMessagePromptTemplate,`
`17`	`16`	`ChatPromptTemplate,`
`18`	`17`	`HumanMessagePromptTemplate,`
`19`	`18`	`MessagesPlaceholder,`
`20`	`19`	`)`
	`20`	`+from langchain_core.prompts.message import BaseMessagePromptTemplate`
`21`	`21`	`from langchain_core.runnables import Runnable, RunnablePassthrough`
`22`	`22`	`from langchain_core.tools import BaseTool`
`23`	`23`	`from langchain_core.utils.function_calling import convert_to_openai_function`
Original file line number	Diff line number	Diff line change
`@@ -17,11 +17,11 @@`
`17`	`17`	`)`
`18`	`18`	`from langchain_core.prompts import BasePromptTemplate`
`19`	`19`	`from langchain_core.prompts.chat import (`
`20`		`- BaseMessagePromptTemplate,`
`21`	`20`	`ChatPromptTemplate,`
`22`	`21`	`HumanMessagePromptTemplate,`
`23`	`22`	`MessagesPlaceholder,`
`24`	`23`	`)`
	`24`	`+from langchain_core.prompts.message import BaseMessagePromptTemplate`
`25`	`25`	`from langchain_core.tools import BaseTool`
`26`	`26`	`from pydantic import model_validator`
`27`	`27`	`from typing_extensions import Self`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`	`ensure_config,`
`28`	`28`	`run_in_executor,`
`29`	`29`	`)`
`30`		`-from langchain_core.runnables.utils import create_model`
	`30`	`+from langchain_core.utils.pydantic import create_model`
`31`	`31`	`from pydantic import (`
`32`	`32`	`BaseModel,`
`33`	`33`	`ConfigDict,`