Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined constant "LARAVEL_START" in health-up.blade #836

Closed
codebarista opened this issue Feb 7, 2024 · 5 comments
Closed

Undefined constant "LARAVEL_START" in health-up.blade #836

codebarista opened this issue Feb 7, 2024 · 5 comments

Comments

@codebarista
Copy link

Octane Version

v2.3.2

Laravel Version

11.x-dev

PHP Version

8.3.2

What server type are you using?

FrankenPHP

Server Version

1.1.0

Database Driver & Version

No response

Description

Possibly a general issue, but in my test installation of the new Laravel 11 (dev), the "health" route throws an exception. The reason is that the constant LARAVEL_START is used in health-up.blade.php. The constant is not present, at least with FrankenPHP. The default artisan serve works.

https://github.com/laravel/framework/blob/fa1e70a74c202d15db8a856eca1d3d17a93350d6/src/Illuminate/Foundation/resources/health-up.blade.php#L41

Steps To Reproduce

  • install Laravel 11 (with laravel installer)
  • install Octane with option frankenphp
  • run php artisan octane:start
  • go to http://127.0.0.1:8000/up
Copy link

github-actions bot commented Feb 8, 2024

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

@driesvints
Copy link
Member

Would appreciate a PR here!

@driesvints
Copy link
Member

Fixed!

@codebarista
Copy link
Author

Would appreciate a PR here!

Sorry, you're right. We use the awesome Laravel a lot for our projects. I have now forked the repositories and will try my hand at PRs in the future. Thanks for your fix. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@taylorotwell @driesvints @nunomaduro @codebarista and others