You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Laravel uses Monolog for logging, some monolog handler have a important close() function.
Octane does never call this function! In normal laravel applications, monolog calls close by itself via __destruct().
It seams like __destruct() is never called in Swoole and it could be sensible to call close() after every request.
Taking into account that there is currently only one workaround to write performant logs: #724 (comment)
In this case the ProcessHandler::close() is never called and laravel will spawn endless cat processes.
Steps To Reproduce
Create an endpoint that writes information to the Log facade
As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.
If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.
Octane Version
2.3.4
Laravel Version
10.46.0
PHP Version
8.1.27
What server type are you using?
Swoole
Server Version
5.1.2
Database Driver & Version
No response
Description
Laravel uses Monolog for logging, some monolog handler have a important
close()
function.Octane does never call this function! In normal laravel applications, monolog calls close by itself via
__destruct()
.It seams like
__destruct()
is never called in Swoole and it could be sensible to callclose()
after every request.Taking into account that there is currently only one workaround to write performant logs: #724 (comment)
In this case the
ProcessHandler::close()
is never called and laravel will spawn endlesscat
processes.Steps To Reproduce
close()
call, like in Logging in requests is very slow #724 (comment)ps
and see that for every request acat
process was created but not closed.The text was updated successfully, but these errors were encountered: