Skip to content

Commit 024c0df

Browse files
committed
attempt to suppress TODO lint failures
1 parent fa2b9e6 commit 024c0df

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

internal/datasourcev2/polling_data_source.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ func (pp *PollingProcessor) poll() error {
152152
return nil
153153
}
154154

155+
//nolint:godox
155156
// TODO(SDK-712): If the destination fails to apply the updates should it affect the processor?
156157
// This would only happen in the case of a persistent store.
157158
switch response.Intent() {

internal/datasourcev2/streaming_data_source.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ func (sp *StreamProcessor) Start(closeWhenReady chan<- struct{}) {
129129

130130
// TODO(SDK-713): Refactor the implementation of this function to lower the complexity.
131131
//
132-
//nolint:gocyclo,godox // this function is a stepping stone. It will get better over time.
132+
//nolint:godox
133133
func (sp *StreamProcessor) consumeStream(stream *es.Stream, closeWhenReady chan<- struct{}) {
134134
// Consume remaining Events and Errors so we can garbage collect
135135
defer func() {
@@ -251,6 +251,7 @@ func (sp *StreamProcessor) consumeStream(stream *es.Stream, closeWhenReady chan<
251251
break
252252
}
253253

254+
//nolint:godox
254255
// TODO(SDK-712): If the destination fails to apply the updates should it affect the processor?
255256
// This would only happen in the case of a persistent store.
256257

internal/datasystem/store.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ func (s *Store) init(allData []ldstoretypes.Collection, selector *fdv2proto.Sele
167167
s.active = s.memoryStore
168168

169169
if s.shouldPersist() {
170+
//nolint:godox
170171
// TODO(SDK-711): We need to sort the data in dependency order before inserting it.
171172
return s.persistentStore.impl.Init(allData)
172173
}
@@ -197,6 +198,7 @@ func (s *Store) ApplyDelta(events []fdv2proto.Event, selector *fdv2proto.Selecto
197198
// is happening. In practice, we often don't receive more than one event at a time, but this may change
198199
// in the future.
199200
if s.shouldPersist() {
201+
//nolint:godox
200202
// TODO(SDK-711): We need to sort the data in dependency order before inserting it.
201203
for _, coll := range collections {
202204
for _, item := range coll.Items {

0 commit comments

Comments
 (0)