Fix: Correct handling of import module as alias in LPython semantic analysis
#2872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where import statements with aliases (e.g.,
import numpy as np) would load the module correctly but fail to register the alias (np) in the current scope. As a result, subsequent code using the alias (likenp.array()) would fail withNameError: 'np' is not defined.This patch updates the semantic analysis phase to ensure import aliases are correctly created and installed into the symbol table as
ExternalSymbols.Technical Changes
visit_Importinsrc/lpython/semantics/python_ast_to_asr.cpp:x.m_names[i].m_asname) to be lost before the symbol registration step.ASR::ExternalSymbol_tin the current scope.np) to the loaded module symbol (e.g.,numpy), mirroring Python's behavior.Verification
I verified the fix using the following reproduction script
repro.py: