New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

va: reduce duplication in "Validation result" log message #7581

Open

jsha opened this issue Jul 9, 2024 · 1 comment

Contributor

jsha commented Jul 9, 2024

When we log a validation result with an error, it shows up three places:

We log the updated challenge object, which includes the error
We log the error at the top level of the JSON object
We log the internal error

We should fix this by:

Not logging the updated challenge object
Logging the internal error only if it differs from the external error (modulo the prefix of the error type)

Contributor

mcpherrinm commented Jul 10, 2024

One error that has caused confusion for users is errors of the form

dns :: no valid A records found for example.com; no valid AAAA records found for example.com

I haven't looked at how that's generated, but could we collapse those errors to no valid A or AAAA records found for example.com as a special-case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment