Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend liblouis.org to switch to HTTPS #1

Open
dpy013 opened this issue Feb 26, 2019 · 21 comments
Open

Recommend liblouis.org to switch to HTTPS #1

dpy013 opened this issue Feb 26, 2019 · 21 comments
Assignees
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request

Comments

@dpy013
Copy link

dpy013 commented Feb 26, 2019

Hello liblouis developers, the current lliblouis.org is still using http1.1, and HTTPS is rapidly gaining popularity, based on security issues, I suggest that liblouis.org can switch to HTTPS thank.
@bertfrees

@bertfrees bertfrees assigned bertfrees and egli and unassigned bertfrees Feb 26, 2019
@dpy013
Copy link
Author

dpy013 commented Feb 26, 2019

GitHub pages are now ready to issue letsencrypt ssl.
Of course, you can also use Comrade ssl of cloudflare cdn.

@egli
Copy link
Member

egli commented Feb 26, 2019

@dpy013
Copy link
Author

dpy013 commented Jun 19, 2019

hi @egli
Is this issue solved now?
thank

@egli
Copy link
Member

egli commented Jun 20, 2019

@dingpengyu not as far as I know. Would you like to work on it? As far as I know all that is needed is to change all the links to images (which I think there are none), links to CSS and Javascript according to the description in the link above.

@dpy013
Copy link
Author

dpy013 commented Aug 28, 2019

@dingpengyu not as far as I know. Would you like to work on it? As far as I know all that is needed is to change all the links to images (which I think there are none), links to CSS and Javascript according to the description in the link above.

I will submit a PR when I arrive.

@egli egli added the help wanted Indicates that a maintainer wants help on an issue or pull request label Aug 28, 2019
@egli
Copy link
Member

egli commented Aug 28, 2019

Cool, thanks

@dpy013
Copy link
Author

dpy013 commented Sep 3, 2019

hi egli
This is the https version of the liblouis website, which runs very well under my domain name.
I didn't find anything that needs to be changed. Can you help me with the test? If you need to modify it, you can post a comment below. Thank you
open liblouis https test website

@dpy013
Copy link
Author

dpy013 commented Sep 3, 2019

cc @egli

@egli
Copy link
Member

egli commented Sep 3, 2019

Looks good. How do we get the liblouis.org domain to be under https?

@dpy013
Copy link
Author

dpy013 commented Sep 3, 2019

First open liblouis.github.io, then open the settings, then select the Enforce HTTPS checkbox to select him.

@egli
Copy link
Member

egli commented Sep 3, 2019

Ah, yes, I see that button. But it says

Enforce HTTPS — Unavailable for your site because your domain is not properly configured to support HTTPS (liblouis.org) — Troubleshooting custom domains

Presumably the problem is what is mentioned above

The custom domain for your GitHub Pages site is pointed at an outdated IP address. You must update your site's DNS records if you'd like it to be available via your custom domain. For more information, see https://help.github.com/articles/setting-up-a-custom-domain-with-github-pages/.

I need to contact the people at ViewPlus. They maintain the DNS record

@dpy013
Copy link
Author

dpy013 commented Sep 3, 2019

Ah, yes, I see that button. But it says

Enforce HTTPS — Unavailable for your site because your domain is not properly configured to support HTTPS (liblouis.org) — Troubleshooting custom domains

Presumably the problem is what is mentioned above

The custom domain for your GitHub Pages site is pointed at an outdated IP address. You must update your site's DNS records if you'd like it to be available via your custom domain. For more information, see https://help.github.com/articles/setting-up-a-custom-domain-with-github-pages/.

I need to contact the people at ViewPlus. They maintain the DNS record

The current pr seems to have completed his mission in my opinion, I am going to close him, what do you think?
thank

@egli
Copy link
Member

egli commented Sep 3, 2019

You want to close this issue? Why? It is nowhere near finished.

@dpy013
Copy link
Author

dpy013 commented Sep 3, 2019

You want to close this issue? Why? It is nowhere near finished.

Well, wait for the site to start https in closing this issue. My idea is that I have already told you the method. So I think that this pr has completed his task.
sorry

@dpy013
Copy link
Author

dpy013 commented Sep 5, 2019

How is the website configured?

@egli
Copy link
Member

egli commented Sep 5, 2019

What do you mean? It has a custom domain (liblouis.org) and https is not enforced.

@dpy013
Copy link
Author

dpy013 commented Sep 5, 2019

Configure the Custom domain editable text www.dpy06.com domain, then select the Enforce HTTPS checkbox

@egli
Copy link
Member

egli commented Sep 5, 2019

Well, of course I want the custom domain to be 'liblouis.org'

@dpy013
Copy link
Author

dpy013 commented Sep 8, 2019

Well, of course I want the custom domain to be 'liblouis.org'

Custom domain name is completely ok, you can follow the example above.

@dpy013
Copy link
Author

dpy013 commented Sep 8, 2019

I just cloned your website repository and bound my domain name.

@dpy013
Copy link
Author

dpy013 commented Oct 19, 2019

Does this issue continue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Development

No branches or pull requests

3 participants