Introduce new mandatory NodeEntropy object
#716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we're about to expose more entropy-related things, we here introduce a new module and start moving related types there.
Now that we don't use the `Runtime` in `VssStore` anymore, we can in fact revert to reuse the public interface.
|
👋 Thanks for assigning @benthecarman as a reviewer! |
tnull
force-pushed
the
2025-11-introduce-mandatory-node-entropy
branch
9 times, most recently
from
dac3510 to
982f8b1
Compare
Previously, the `Builder` allowed setting different entropy sources via its `set_entropy...` methods, defaulting to sourcing from an auto-generated seed file in the storage path. While this allowed for really easy setup, it spared the user to actually think about where to store their node secret. Here, we therefore introduce a mandatory `NodeEntropy` object that, as before, allows the user to source entropy from BIP39 Mnemonic, seed bytes, or a seed file. However, it doesn't implement any default and hence intentionally requires manually setup by the user. Moreover, this API refactor also allows to reuse the same object outside of the `Node`'s `Builder` in a future commit.
tnull
force-pushed
the
2025-11-introduce-mandatory-node-entropy
branch
from
982f8b1 to
c06b118
Compare
We add a simple test calling `read_or_generate_seed_file` twice, asserting it returns the same value in both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at #240.
This is a prefactor for a following PR then using
EntropySourcein aVssStoreBuilderto replace #713. Will open that once this one lands.