f fixups

Author: TheBlueMatt

CHANGELOG.md

@@ -14,9 +14,9 @@
    * `KVStore` has been made async. Note that `KVStore` methods are not
      `async fn`, but rather write ordering is fixed when the methods return,
      though write completion is async.
-   * `BumpTransactionEventHandler` is no backed by an async `WalletSource` (and
+   * `BumpTransactionEventHandler` is now backed by an async `WalletSource` (and
      `Wallet`) or an async `CoinSelectionSource` and is now async. Sync versions
-     are in the new `sync` submodule (#3752).
+     are in the new `events::bump_transaction::sync` submodule (#3752).
    * `OutputSweeper` is now backed by an async `KVStore` and
      `ChangeDestinationSource` and is now async (#3819, #3734, #4131).
    * `MonitorUpdatingPersisterAsync` and `ChainMonitor::new_async_beta` were
@@ -33,7 +33,7 @@
    LDK-based LSPs wishing to support often-offline senders and recipients should
    set `UserConfig::enable_htlc_hold`, support the existing "onion mesage
    mailbox" feature (setting `intercept_messages_for_offline_peers` on
-   `OnionMessegner` and handling `Event::OnionMessageIntercepted`s), and handle
+   `OnionMessenger` and handling `Event::OnionMessageIntercepted`s), and handle
    `Event::PersistStaticInvoice`s and `Event::StaticInvoiceRequested`s.
  * Zero-Fee-Commitment channels are now supported in LDK. These channels remove
    force-closure risk for feerate disagreements by using a fixed, zero fee on
@@ -42,7 +42,6 @@
    breaking compatibility. This is negotiated automatically for
    manually-accepted inbound channels and negotiated for outbound channels based
    on `ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx`.
-
  * `Event::BumpTransaction` is now always generated even if the transaction has
    sufficient fee. This allows you to manage transaction broadcasting more
    granularly for anchor channels (#4001).
@@ -54,8 +53,10 @@
  * `LSPS2ClientEvent` now has events for failure events (#3804).
  * `LSPS2ServiceHandler::channel_open_abandoned` was added (#3712).
  * `Event::PendingHTLCsForwardable` has been replaced with regular calls to
-   `process_pending_htlc_forwards` in the background processor when
-   `ChannelManager::needs_pending_htlc_processing` is true (#3891, #3955).
+   `process_pending_htlc_forwards` in the background processor while
+   `ChannelManager::needs_pending_htlc_processing` is true. The delay between
+   calls (and, thus, HTLC forwarding delay) is random between zero and 200ms,
+   averaging 50ms, faster than the previous recommendation (#3891, #3955).
  * `Event::HTLCHandlingFailed`s now include a`LocalHTLCFailureReason`, providing
    much more granular reasons for HTLCs having been failed (#3744, etc).
  * `Event::HTLCHandlingFailed` is now generated any time forwarding an HTLC
@@ -78,8 +79,8 @@
  * Repeated `Listen::block_disconnected` calls for each disconnected block in a
    reorg have been replaced with a single `blocks_disconnected` call with the
    fork point block (i.e. the highest block on both sides of the reorg, #3876).
- * `lightning::routing::scoring::CombinedScorer` was added to better support
-   nodes using both remote scoring info and their own payment results (#3562).
+ * `lightning::routing::scoring::CombinedScorer` was added to combine scoring
+   data between remote scoring info and local payment results (#3562).
  * LDK will now store up to 1KiB of "peer storage" data in `ChannelManager` per
    peer with which we have a funded channel (#3575).
  * `ProbabilisticScoringFeeParameters::probing_diversity_penalty` was added to
@@ -138,6 +139,10 @@
 ## Backwards Compatibility
  * `ChannelMonitor`s which were created prior to LDK 0.0.110 and which saw no
    updates since LDK 0.0.116 may now fail to deserialize (#3638, #4146).
+ * Setting `v2_remote_key_derivation` on `KeysManager` to true, or splicing a
+   channel results in using keys which prior versions of LDK do not know how to
+   derive. This may result in missing funds or panics trying to sweep closed
+   channels after downgrading (#4117).
  * After upgrading to 0.2, downgrading to versions of LDK prior to 0.0.123 is no
    longer supported (#2933).
  * Blinded paths generated by previous versions of LDK, except those generated