-
Notifications
You must be signed in to change notification settings - Fork 421
Open
Labels
Milestone
Description
Shouldn't hold up this PR, but is there any reason why we don't simply add a
TxAbortvariant toInteractiveTxMessageSend? Then we wouldn't need eitherInteractiveTxMessageSendResultorHandleTxCompleteResult, IIUC, which would remove two layers of structs.Otherwise, we go through the following conversions just to end up with a
MessageSendEvent:
Result<InteractiveTxMessageSend, AbortReason>InteractiveTxMessageSendResult(Result<InteractiveTxMessageSend, msgs::TxAbort>)MessageSendEventThe
Results don't seem to buy us anything more than the extra variant would as we aren't doing anything special for theErrcase. Then it would simply be:
InteractiveTxMessageSendMessageSendEventAnd AFAICT,
InteractiveTxConstructorhas thechannel_id, so there's no need to grab it from theChannelContext. Or will it change in some case?
Originally posted by @jkczyz in #3137 (comment)