Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BackgroundProcessor::start_without_om #3612

Open
TheBlueMatt opened this issue Feb 21, 2025 · 4 comments
Open

Add BackgroundProcessor::start_without_om #3612

TheBlueMatt opened this issue Feb 21, 2025 · 4 comments
Milestone
0.2

Comments

@TheBlueMatt
Copy link
Collaborator

BackgroundProcessor::start takes an Option for the OnionMessenger which is quite annoying as it requires a concrete type for the OnionMessenger even when passing None. We should add a new constructor to make this easier for users.
@TheBlueMatt TheBlueMatt added this to the 0.2 milestone Feb 21, 2025
@Anyitechs
Copy link

Hi @TheBlueMatt, I'll like to work on this issue. Can it be assigned to me please?

@TheBlueMatt
Copy link
Collaborator Author

Go for it!

@Anyitechs
Copy link

Go for it!

Thank you @TheBlueMatt. On it!

@tnull
Copy link
Contributor

tnull commented Mar 3, 2025

It might be a bit late to mention this, but given that we'll need to introduce similar variants for LiquidiityManager in/post #3509, I wonder if we should use a builder pattern or have the BP take a BackgroundProcessorConfig or similar?

Otherwise the API might get a bit messy if we add constructors for all combinations of parameters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
3 participants
@tnull @TheBlueMatt @Anyitechs