Commit 1fa4b49
committed
fix(review): log transport errors before treating as failed probe
The previous fix used `unwrap_or(false)` which silently discarded the
error details. Operators debugging why a worker won't come Ready had no
visibility into the underlying cause (connection refused, TLS failure,
DNS resolution failure, timeout, etc.).
Switched to `unwrap_or_else` which logs the error with the worker URL
at warn level before returning false. This preserves the existing
state-machine behavior (transport errors still count as failed probes
and feed the Pending timeout / NotReady→Failed paths) while making the
underlying cause discoverable from logs.
Refs: PR #1102 review feedback
Signed-off-by: Simo Lin <linsimo.mark@gmail.com>1 parent cec40bf commit 1fa4b49
1 file changed
Lines changed: 15 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
610 | 610 | | |
611 | 611 | | |
612 | 612 | | |
613 | | - | |
614 | | - | |
615 | | - | |
616 | | - | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
617 | 619 | | |
618 | 620 | | |
619 | | - | |
620 | | - | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
621 | 630 | | |
622 | 631 | | |
623 | 632 | | |
| |||
0 commit comments