Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is doctrine/doctrine-fixtures-bundle required when using theofidry/alice-data-fixtures? #86

Open
tifabien opened this issue Oct 30, 2018 · 1 comment
Assignees
Labels
internal Updates that won't affect the API
Milestone

Comments

@tifabien
Copy link

Hi all,

I just installed and tried the new v2.0-alpha8 and got a question related to the doctrine/doctrine-fixtures-bundle dependency requirement.
Indeed when I'm using the theofidry/alice-data-fixtures it seems that it needs also the doctrine/doctrine-fixtures-bundle package which seems not really necessary as I think both bundles are doing the same thing.

From what I understand I can see that the requirement check is done when the loadAliceFixture calls the cleanDatabase method.
So my question is : Do we really need both bundles?
Thanks !

@alexislefebvre alexislefebvre transferred this issue from liip/LiipFunctionalTestBundle Jan 13, 2021
@alexislefebvre
Copy link
Collaborator

alexislefebvre commented Jul 20, 2021

Here is the relevant code:

if (null === $this->loader) {
throw new \BadMethodCallException('doctrine/doctrine-fixtures-bundle must be installed to use this method.');
}

It was added in liip/LiipFunctionalTestBundle#432

Right now doctrine/doctrine-fixtures-bundle is mentioned in the suggest config of composer.json but not mentioned in the documentation. So maybe it should be added as a dependency, it was a suggestion before the fixtures loading was splited from https://github.com/liip/LiipFunctionalTestBundle.

@alexislefebvre alexislefebvre self-assigned this Jul 20, 2021
@alexislefebvre alexislefebvre added this to the 2.x milestone Jul 20, 2021
@alexislefebvre alexislefebvre added the internal Updates that won't affect the API label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Updates that won't affect the API
Projects
None yet
Development

No branches or pull requests

2 participants