Skip to content

Commit fc90691

Browse files
Ayeshboite
authored andcommitted
fix(reviewdog): fix installation and directly install to /usr/local/bin #0000
The `*-review` images include `reviewdog`, installed by `curl | sh`-ing the `install.sh`. Following a recent change[^1], the default installation directory has changed. This updates the `*-review` `Dockerfile`s to be compatible with the `install.sh` changes by directly specifying the installation directory. Previously, this required manually moving the executable, but from now on, the installation directory is specified as a flag to the `install.sh` script. [^1]: reviewdog/reviewdog@a547abe
1 parent fbfd309 commit fc90691

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

Dockerfile.php7-review

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ RUN git clone https://github.com/linkorb/php-tools.git
1414
RUN cd php-tools && COMPOSER_MEMORY_LIMIT=-1 /usr/bin/composer install
1515

1616
# install reviewdog
17-
RUN curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s
18-
RUN mv /opt/bin/reviewdog /usr/local/bin
17+
RUN curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b /usr/local/bin
1918

2019
# add php-tools to search path globally
2120
RUN echo "export PATH=$PATH:/opt/php-tools/bin" >> /etc/bash.bashrc

Dockerfile.php8-review

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ WORKDIR /opt/
1010
ENV COMPOSER_ALLOW_SUPERUSER=1
1111

1212
# install reviewdog
13-
RUN curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s
14-
RUN mv /opt/bin/reviewdog /usr/local/bin
13+
RUN curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b /usr/local/bin
1514

1615
RUN composer global require icanhazstring/composer-unused \
1716
&& ln -s /root/.config/composer/vendor/bin/composer-unused /usr/local/bin/composer-unused

0 commit comments

Comments
 (0)