refactor(dashboard-manager): Extract focused providers from DashboardManagerProvider (#588)

* refactor(dashboard-manager): Extract focused providers from DashboardManagerProvider

- Extract device info data into dedicated `deviceInfoProvider`
- Extract ethernet ports data into `ethernetPortsProvider`
- Extract router time data into `routerTimeProvider`
- Extract system stats data into `systemStatsProvider`
- Extract WiFi radios data into `wifiRadiosProvider`
- Add `polling_helpers.dart` for shared polling data extraction utilities
- Rename `DashboardManagerProvider` to `SessionProvider` for session operations
- Rename `DashboardManagerService` to `SessionService` for clarity
- Update all consumers to use new focused providers
- Add comprehensive unit tests for all new providers
- Remove obsolete `DashboardManagerState` and related files

* feat(tools): Add --collect flag to run_screenshot_tests.dart

- Add new `--collect` / `-p` flag to collect golden files after tests
- Implement `_copyGoldensToSnapshots()` function to copy all golden files from test directories to snapshots folder
- Fix issue where golden files were never collected when using the Dart tool (since it always passes `-f` to shell script)

* fix(providers): Replace undefined dashboardManagerProvider with ethernetPortsProvider

- Fix instant_verify_view.dart using undefined dashboardManagerProvider
- Fix wifi_bundle_provider.dart using undefined dashboardManagerProvider

* fix(test): Use correct SharedPreferences key constants in session_provider_test

- Add import for pref_key.dart constants
- Replace hardcoded 'currentSN' with pCurrentSN constant
- Replace hardcoded 'selectedNetworkId' with pSelectedNetworkId constant
- Replace hardcoded 'pnpConfiguredSN' with pPnpConfiguredSN constant

* test(wifi-bundle): Refactor wifi_bundle_provider_test.dart for better test design

- Add ethernetPortsProvider mock override to match provider dependencies
- Extract createRadiosTestData() helper function for test data creation
- Refactor seedWithRadios() to properly set state before container creation
- Add documentation comments explaining the test setup sequence

Author: HankYuLinksys

lib/app.dart

@@ -175,7 +175,7 @@ class _LinksysAppState extends ConsumerState<LinksysApp>
     //       .then((prefs) {
     //     final currentSN = prefs.getString(pCurrentSN);
     //     if (currentSN != null &&
-    //         ref.read(dashboardManagerProvider).deviceInfo?.serialNumber !=
+    //         ref.read(sessionProvider).deviceInfo?.serialNumber !=
     //             currentSN) {
     //       // if (mounted) {
     //       //   showRouterNotFoundAlert(context, ref);

lib/core/data/providers/dashboard_manager_provider.dart

@@ -0,0 +1,45 @@
+import 'package:equatable/equatable.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:privacy_gui/core/jnap/actions/better_action.dart';
+import 'package:privacy_gui/core/jnap/models/device_info.dart';
+import 'package:privacy_gui/core/jnap/models/soft_sku_settings.dart';
+import 'package:privacy_gui/core/data/providers/polling_provider.dart';
+import 'package:privacy_gui/core/data/providers/polling_helpers.dart';
+
+final deviceInfoProvider = Provider<DeviceInfoState>((ref) {
+  final pollingData = ref.watch(pollingProvider).value;
+
+  NodeDeviceInfo? deviceInfo;
+  String? skuModelNumber;
+
+  final deviceInfoOutput =
+      getPollingOutput(pollingData, JNAPAction.getDeviceInfo);
+  if (deviceInfoOutput != null) {
+    deviceInfo = NodeDeviceInfo.fromJson(deviceInfoOutput);
+  }
+
+  final skuOutput =
+      getPollingOutput(pollingData, JNAPAction.getSoftSKUSettings);
+  if (skuOutput != null) {
+    final settings = SoftSKUSettings.fromMap(skuOutput);
+    skuModelNumber = settings.modelNumber;
+  }
+
+  return DeviceInfoState(
+    deviceInfo: deviceInfo,
+    skuModelNumber: skuModelNumber,
+  );
+});
+
+class DeviceInfoState extends Equatable {
+  final NodeDeviceInfo? deviceInfo;
+  final String? skuModelNumber;
+
+  const DeviceInfoState({
+    this.deviceInfo,
+    this.skuModelNumber,
+  });
+
+  @override
+  List<Object?> get props => [deviceInfo, skuModelNumber];
+}

lib/core/data/providers/dashboard_manager_state.dart

@@ -0,0 +1,37 @@
+import 'package:equatable/equatable.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:privacy_gui/core/jnap/actions/better_action.dart';
+import 'package:privacy_gui/core/data/providers/polling_provider.dart';
+import 'package:privacy_gui/core/data/providers/polling_helpers.dart';
+
+final ethernetPortsProvider = Provider<EthernetPortsState>((ref) {
+  final pollingData = ref.watch(pollingProvider).value;
+
+  String? wanConnection;
+  List<String> lanConnections = [];
+
+  final portsOutput =
+      getPollingOutput(pollingData, JNAPAction.getEthernetPortConnections);
+  if (portsOutput != null) {
+    wanConnection = portsOutput['wanPortConnection'] as String?;
+    lanConnections = List<String>.from(portsOutput['lanPortConnections'] ?? []);
+  }
+
+  return EthernetPortsState(
+    wanConnection: wanConnection,
+    lanConnections: lanConnections,
+  );
+});
+
+class EthernetPortsState extends Equatable {
+  final String? wanConnection;
+  final List<String> lanConnections;
+
+  const EthernetPortsState({
+    this.wanConnection,
+    this.lanConnections = const [],
+  });
+
+  @override
+  List<Object?> get props => [wanConnection, lanConnections];
+}

lib/core/data/providers/device_info_provider.dart

@@ -0,0 +1,24 @@
+import 'package:privacy_gui/core/jnap/actions/better_action.dart';
+import 'package:privacy_gui/core/jnap/result/jnap_result.dart';
+import 'package:privacy_gui/core/data/providers/polling_provider.dart';
+
+/// Extracts the output Map from polling data for a specific action.
+Map<String, dynamic>? getPollingOutput(
+  CoreTransactionData? data,
+  JNAPAction action,
+) {
+  return _getPollingSuccess(data, action)?.output;
+}
+
+/// Safely extracts a successful result for a specific action from polling data.
+///
+/// Returns null if the data is null, the action is not found, or the result
+/// is not a JNAPSuccess (e.g., it's a JNAPError).
+JNAPSuccess? _getPollingSuccess(
+  CoreTransactionData? data,
+  JNAPAction action,
+) {
+  if (data == null) return null;
+  final result = data.data[action];
+  return result is JNAPSuccess ? result : null;
+}

lib/core/data/providers/ethernet_ports_provider.dart

@@ -0,0 +1,27 @@
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:intl/intl.dart';
+import 'package:privacy_gui/core/jnap/actions/better_action.dart';
+import 'package:privacy_gui/core/data/providers/polling_provider.dart';
+import 'package:privacy_gui/core/data/providers/polling_helpers.dart';
+
+/// Provides the router's local time as milliseconds since epoch.
+///
+/// Extracts the current time from polling data for getLocalTime action.
+/// Falls back to the current system time if unable to retrieve router time.
+final routerTimeProvider = Provider<int>((ref) {
+  final pollingData = ref.watch(pollingProvider).value;
+
+  final timeOutput = getPollingOutput(pollingData, JNAPAction.getLocalTime);
+  if (timeOutput != null) {
+    final timeString = timeOutput['currentTime'] as String?;
+    if (timeString != null) {
+      final parsedTime =
+          DateFormat("yyyy-MM-ddThh:mm:ssZ").tryParse(timeString);
+      if (parsedTime != null) {
+        return parsedTime.millisecondsSinceEpoch;
+      }
+    }
+  }
+
+  return DateTime.now().millisecondsSinceEpoch;
+});