fix: enable antialiasing for photo/video buttons.#406
Merged
Conversation
The photo and video buttons were displaying with blurry edges due to missing antialiasing settings in Qt6. The paintEvent method only set HighQualityAntialiasing for Qt5 and below, leaving Qt6 versions without any antialiasing. This fix adds proper antialiasing support for Qt6 using the standard Antialiasing render hint. Log: adapt Qt6 antialiasing Bug: https://pms.uniontech.com/bug-view-307777.html
Reviewer's guide (collapsed on small PRs)Reviewer's GuideExtend photoRecordBtn paintEvent to enable QPainter antialiasing under Qt6, matching existing Qt5 behavior and eliminating blurry button edges. Class diagram for updated photoRecordBtn antialiasing logicclassDiagram
class photoRecordBtn {
+void paintEvent(QPaintEvent *event)
}
class QPainter {
+void setRenderHint(RenderHint, bool)
}
photoRecordBtn --> QPainter : uses
Flow diagram for antialiasing selection in paintEventflowchart TD
A["paintEvent() called"] --> B{Qt Version}
B -- "Qt5 or below" --> C["setRenderHint(HighQualityAntialiasing, true)"]
B -- "Qt6 or above" --> D["setRenderHint(Antialiasing, true)"]
C --> E["Continue painting"]
D --> E
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这个代码修改进行审查:
改进建议: void photoRecordBtn::paintEvent(QPaintEvent *event)
{
QPainter painter(this);
// 设置抗锯齿渲染,适配不同Qt版本
#if QT_VERSION_MAJOR <= 5
painter.setRenderHint(QPainter::HighQualityAntialiasing);
#else
painter.setRenderHint(QPainter::Antialiasing);
#endif
painter.setBrush(Qt::NoBrush);
// ... 其余绘制代码
}主要改进点:
这些改动虽然不大,但能提高代码的可读性和维护性。 |
lzwind
approved these changes
Oct 20, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The photo and video buttons were displaying with
blurry edges due to missing antialiasing settings in Qt6. The paintEvent method only set HighQualityAntialiasing for Qt5 and below, leaving Qt6 versions without any antialiasing. This fix adds proper antialiasing support for Qt6 using the standard Antialiasing render hint.
Log: adapt Qt6 antialiasing
Bug: https://pms.uniontech.com/bug-view-307777.html
Summary by Sourcery
Bug Fixes: