-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gTile: coherently update ui on monitor change, move gnome terminal #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please build the 3.8 version as well.
Also, while you are at it, could you fix a bug that are introduced?
Showing the Grid UI right after restarting Cinnamon breaks.
The problem is that the current monitor is not updated before it tries to get the current grid, here: https://github.com/settenop/cinnamon-spices-extensions/blob/master/gTile%40shuairan/src/base/app.ts#L285
The fix is to move this line https://github.com/settenop/cinnamon-spices-extensions/blob/master/gTile%40shuairan/src/base/app.ts#L288 above the other one I linked.
I'm sorry, can you revert my proposed fix? It breaks other behaviour, like mouse switching between windows. Apologies, I will fix that issue properly later |
Apart from that, everything is ok |
pls note i had to run |
Could we fix it using always the same grid when public get CurrentGrid(): Grid {
if (!this.config.showGridOnAllMonitors) {
return this.grids[0];
}
const grid = this.grids.find(x => x.monitor.index == this.currentMonitor.index)!;
return grid;
} Edit: if (!this.config.showGridOnAllMonitors) {
if (this.CurrentGrid) {
this.CurrentGrid.ChangeCurrentMonitor(this.monitors[this.focusMetaWindow.get_monitor()]);
}
} |
Had a bit of time to look today, the problem is that the function is executed twice, here first: So these 2 lines can be removed. Of course a null check would definitely help, even tho |
yes, I've found some issues too.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about this PR. Btw the proper way to fix the build is to update the webpack version to the latest.
@Gr3q Any update on merging this? Would really like to use gTile with my terminal :D |
@brownsr is the one who reviews and merges PRs |
Sorry for the long wait, I hadn't seen there was a change waiting here. Unfortunately there are conflicts. Can you resolve these, and then I should be able to merge. Regards Simon |
@settenop This PR is now too old. Please create a new one after synchronizing your master branch fork. |
Hi, the extension had some unintuitive behaviour for me in multimonitor so i made the following changes:
Then i noticed the terminal was not moving, so:
This should fix #425
Could you review it pls? @Gr3q @shuairan
Only tested in Cinnamon 5.4.12