Skip to content

Commit ff36fb8

Browse files
committed
Apply early-return-pattern to reduce nesting & cognitive complexity
1 parent 0fe824b commit ff36fb8

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

src/room/errors.ts

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -98,17 +98,20 @@ export enum MediaDeviceFailure {
9898

9999
export namespace MediaDeviceFailure {
100100
export function getFailure(error: any): MediaDeviceFailure | undefined {
101-
if (error && 'name' in error) {
102-
if (error.name === 'NotFoundError' || error.name === 'DevicesNotFoundError') {
103-
return MediaDeviceFailure.NotFound;
104-
}
105-
if (error.name === 'NotAllowedError' || error.name === 'PermissionDeniedError') {
106-
return MediaDeviceFailure.PermissionDenied;
107-
}
108-
if (error.name === 'NotReadableError' || error.name === 'TrackStartError') {
109-
return MediaDeviceFailure.DeviceInUse;
110-
}
111-
return MediaDeviceFailure.Other;
101+
if (!error || !('name' in error)) {
102+
return undefined
112103
}
104+
105+
if (error.name === 'NotFoundError' || error.name === 'DevicesNotFoundError') {
106+
return MediaDeviceFailure.NotFound;
107+
}
108+
if (error.name === 'NotAllowedError' || error.name === 'PermissionDeniedError') {
109+
return MediaDeviceFailure.PermissionDenied;
110+
}
111+
if (error.name === 'NotReadableError' || error.name === 'TrackStartError') {
112+
return MediaDeviceFailure.DeviceInUse;
113+
}
114+
115+
return MediaDeviceFailure.Other;
113116
}
114117
}

0 commit comments

Comments
 (0)