Fix publish command to include free components #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario
Some components, such as the
navlist.itemare not being published in v2.The problem
The issue is that the publish command isn't looking for the navlist components in Flux free and instead are still looking for them in Flux Pro.
The solution
The solution is to update the array of components in the publish command to match which package the components are in.
I also had to update the publish script to allow a folder to be parsed twice, as we now have a radio folder in both free and Pro for example.
I did a test of this in both an application with Flux Pro and an application with Flux only and both worked happily.
Fixes #1203