Fix select option variant not found #1213
Open
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario
If you use a default select inside a component that has a variant defined, like a modal, then the select options aren't showing up.
The problem
The issue is that we recently split the select components, so some are free and some are pro, which required the option component to be split into multiple variants, but I didn't add the check back in to make sure that the variant for the option is coming from a select component and not any other components.
The solution
The solution is to update the variant check to include a check to make sure the select variant exists first. Now everything works happily.
Fixes #1209