Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17 peer support #73

Open
deavial opened this issue Oct 26, 2020 · 11 comments · May be fixed by #74
Open

React 17 peer support #73

deavial opened this issue Oct 26, 2020 · 11 comments · May be fixed by #74
Assignees

Comments

@deavial
Copy link

deavial commented Oct 26, 2020

NPM warning [email protected] requires a peer of react@^0.14 || ^15.0.0 || ^16.0.0-alpha but none is installed. You must install peer dependencies yourself. with React 17.

Please release support for the peer dependency.

@ljharb ljharb self-assigned this Oct 26, 2020
ljharb added a commit that referenced this issue Oct 26, 2020
@ljharb ljharb linked a pull request Oct 26, 2020 that will close this issue
@ljharb
Copy link
Owner

ljharb commented Oct 26, 2020

I put up #74; it's blocked by the lack of an enzyme adapter for react 17.

@leepowelldev
Copy link

What about re-writing the tests to use an alternative testing library? How much does it actually use Enzyme? I can't see much usage of it. This means we could release this without waiting for Enzyme adaptor?

@ljharb
Copy link
Owner

ljharb commented Apr 6, 2021

I’m not particularly interested in doing that; and either way, there doesn’t exist an alternative react testing library for testing in a non-browser context.

@ljrodriguez1

This comment has been minimized.

@ljharb

This comment has been minimized.

@Luksys5

This comment has been minimized.

@ljharb

This comment has been minimized.

@sariza369

This comment was marked as spam.

@Vankydwivedi

This comment was marked as spam.

@ljharb

This comment was marked as resolved.

@Vankydwivedi

This comment was marked as spam.

ljharb added a commit that referenced this issue May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants