Skip to content

setup/install_deps.sh doesn't respect python virtual environments #556

@sagiahrac

Description

@sagiahrac

Component

Setup/Standup

Describe the bug

Description

The setup/install_deps.sh script hardcodes pip3 and python3.X commands, causing packages to be installed system-wide even when running inside an activated virtual environment.

Current behavior

  • Ignores the activated virtual environment ($VIRTUAL_ENV).
  • The script hardcodes pip3 for package installation instead of using -m pip install, thereby ignoring the already detected python path. This can cause environment misalignment, especially with tools like uv.

Steps to reproduce

uv venv --python 3.12
source ...
./setup/install_deps.sh

Additional context or screenshots

(llm-d-benchmark) ➜  llm-d-benchmark git:(main) ✗ which python3 
/Users/sagi/repos/llmd/llm-d-benchmark/.venv/bin/python3
(llm-d-benchmark) ➜  llm-d-benchmark git:(main) which pip3   
/usr/bin/pip3

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions