Upcoming breaking BLT changes release #692
white238
announced in
Announcements
Replies: 2 comments 2 replies
-
|
What about BLT_CXX_STD? |
Beta Was this translation helpful? Give feedback.
2 replies
-
|
I think we should also prefix all the options (e.g. BLT_ENABLE_CUDA instead of ENABLE_CUDA). I've seen a lot of projects use the no-prefix style with their own variables and it gets confusing fast which variables affect which project, and there is a high potential for name conflicts. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
BLT and CMake has grown a lot since BLT's creation. It was always the intention to avoid breaking changes but it is time to mature along with CMake. The intention of this is to discuss and socialize changes.
BLT_DEFINESBLT_C_FLAGS,BLT_CXX_FLAGS,BLT_CUDA_FLAGS, andBLT_FORTRAN_FLAGSBLT_EXE_LINKER_FLAGSGNUInstallDirsand remove creating generic paths hereCUDA_LINK_WITH_NVCCandCUDA_SEPARABLE_COMPILATION(note: these are non-prefixed BLT variables)blt_register_library()BLT_EXPORT_THIRDPARTYandblt_export_tpl_targets()BLT_:ENABLE_CUDA,ENABLE_TESTING, etc.YAPF,clang-format, etc.TARGETfromblt_convert_to_system_includesThings that need debating:
blt_prefixed targets, ie,cudaandblt::cudawill just beblt_cudaBLT_CXX_STDBeta Was this translation helpful? Give feedback.
All reactions