New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more IRGen diagnostics in CIRGen #435

Open

bcardosolopes opened this issue Jan 31, 2024 · 0 comments

Member

bcardosolopes commented Jan 31, 2024 •

edited

Loading

We've been missing several ones (8 in CIRGen versus 70 in IRGen) and it's good practice to keep them.

As mentioned by @AaronBallman in the upstream RFC, example here: https://github.com/llvm/llvm-project/blob/fa42589fe31924b6176d7a92691c2f760b04ffd8/clang/lib/CodeGen/CGStmt.cpp#L945

bcardosolopes changed the title ~~Use IRGen diagnostics in CIRGen~~ Use more IRGen diagnostics in CIRGen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment