-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of OpenMP task constructs #499
Comments
This is great! Thanks @eZWALT and @fabianmcg for driving this, looking forward to patch review! |
I cannot find your comment anymore, but this boils down to work that
needs to be done, `CIRGenerator.cpp:164!`:
```
// For OpenMP emit declare reduction functions, if required.
if (astCtx->getLangOpts().OpenMP) {
llvm_unreachable("NYI");
}
```
…On Sun, Mar 10, 2024 at 10:48 AM Walter J.T.V ***@***.***> wrote:
I am seeking insights regarding an issue encountered during testing. When including the <omp.h> library in the test code as shown below:
#include <omp.h>
int main(){
#pragma omp parallel{
}
}
I observed unusual exceptions. This inclusion leads to the CIRGenerator.cpp file reaching a conditional statement that terminates with a llvm_unreachable. While I understand this may be expected behavior, I lack sufficient context to fully comprehend the issue. Could someone explain why the code functions without the inclusion of <omp.h> but raises an exception when included?
This is the most relevant part of the error, if it helps:
NYI
UNREACHABLE executed at /home/walterjtv/Escritorio/Q8/TFG/clangir/clang/lib/CIR/CodeGen/CIRGenerator.cpp:164!
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0. Program arguments: /home/walterjtv/Escritorio/Q8/TFG/clangir-install/bin/clang-19 -fopenmp -fclangir-enable -emit-cir 2_basic_parallel.c -o 2_basic_parallel.cir
1. /usr/include/x86_64-linux-gnu/bits/types.h:155:26: current parser token '__fsid_t'
2. /usr/include/x86_64-linux-gnu/bits/types.h:155:12 <Spelling=/usr/include/x86_64-linux-gnu/bits/typesizes.h:73:24>: parsing struct/union body 'struct (unnamed at /usr/include/x86_64-linux-gnu/bits/types.h:155:12)'
3. /usr/include/x86_64-linux-gnu/bits/types.h:155:12 <Spelling=/usr/include/x86_64-linux-gnu/bits/typesizes.h:73:24>: CIR generation of declaration 'struct (unnamed at /usr/include/x86_64-linux-gnu/bits/types.h:155:12)'
Thank you for your support.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
--
Bruno Cardoso Lopes
http://www.brunocardoso.cc
|
Excuse me, I removed the commented because I thought that opening an issue would be more helpful. I'm pushing a PR in some minutes including implementations of taskwait, taskyield and barrier (Since this 3 have a symmetrical implementation). |
This was referenced Mar 14, 2024
bcardosolopes
pushed a commit
that referenced
this issue
May 1, 2024
This PR is the final fix for issue #499.
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this issue
Oct 2, 2024
This PR is the final fix for issue llvm#499.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this issue
Oct 2, 2024
This PR is the final fix for issue llvm#499.
keryell
pushed a commit
to keryell/clangir
that referenced
this issue
Oct 19, 2024
This PR is the final fix for issue llvm#499.
lanza
pushed a commit
that referenced
this issue
Nov 5, 2024
This PR is the final fix for issue #499.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey everyone, just wanted to give you a heads up that I'll be diving into implementing various task constructs of OpenMP over the next three months. This includes things like taskwait, task, taskloop, taskgroup, and more. @fabianmcg and I are already coordinating efforts, but if anyone else wants to jump in and work on a different construct, feel free to use this thread to chat about it.
Thanks you for this great community, I'm kicking things off by tackling taskwait this weekend.
The text was updated successfully, but these errors were encountered: