diff --git a/clang/lib/Lex/DependencyDirectivesScanner.cpp b/clang/lib/Lex/DependencyDirectivesScanner.cpp index a862abcc44b38..d894c265a07a2 100644 --- a/clang/lib/Lex/DependencyDirectivesScanner.cpp +++ b/clang/lib/Lex/DependencyDirectivesScanner.cpp @@ -419,7 +419,6 @@ static bool isQuoteCppDigitSeparator(const char *const Start, } void Scanner::skipLine(const char *&First, const char *const End) { - char LastNonWhitespace = ' '; for (;;) { assert(First <= End); if (First == End) @@ -430,6 +429,9 @@ void Scanner::skipLine(const char *&First, const char *const End) { return; } const char *Start = First; + // Use `LastNonWhitespace`to track if a line-continuation has ever been seen + // before a new-line character: + char LastNonWhitespace = ' '; while (First != End && !isVerticalWhitespace(*First)) { // Iterate over strings correctly to avoid comments and newlines. if (*First == '"' || diff --git a/clang/unittests/Lex/DependencyDirectivesScannerTest.cpp b/clang/unittests/Lex/DependencyDirectivesScannerTest.cpp index 61f74929c1e98..d2ef27155df94 100644 --- a/clang/unittests/Lex/DependencyDirectivesScannerTest.cpp +++ b/clang/unittests/Lex/DependencyDirectivesScannerTest.cpp @@ -880,6 +880,37 @@ TEST(MinimizeSourceToDependencyDirectivesTest, EXPECT_EQ(pp_eof, Directives[22].Kind); } +TEST(MinimizeSourceToDependencyDirectivesTest, + TestFixedBugThatReportUnterminatedDirectiveFalsely) { + SmallVector Out; + SmallVector Tokens; + SmallVector Directives; + + StringRef Input = "#ifndef __TEST \n" + "#define __TEST \n" + "#if defined(__TEST_DUMMY) \n" + "#if defined(__TEST_DUMMY2) \n" + "#pragma GCC warning \\ \n" + "\"hello!\"\n" + "#else\n" + "#pragma GCC error \\ \n" + "\"world!\" \n" + "#endif // defined(__TEST_DUMMY2) \n" + "#endif // defined(__TEST_DUMMY) \n" + "#endif // #ifndef __TEST \n"; + ASSERT_FALSE( // False on no error: + minimizeSourceToDependencyDirectives(Input, Out, Tokens, Directives)); + ASSERT_TRUE(Directives.size() == 8); + EXPECT_EQ(pp_ifndef, Directives[0].Kind); + EXPECT_EQ(pp_define, Directives[1].Kind); + EXPECT_EQ(pp_if, Directives[2].Kind); + EXPECT_EQ(pp_if, Directives[3].Kind); + EXPECT_EQ(pp_endif, Directives[4].Kind); + EXPECT_EQ(pp_endif, Directives[5].Kind); + EXPECT_EQ(pp_endif, Directives[6].Kind); + EXPECT_EQ(pp_eof, Directives[7].Kind); +} + TEST(MinimizeSourceToDependencyDirectivesTest, PoundWarningAndError) { SmallVector Out;