-
Notifications
You must be signed in to change notification settings - Fork 14.5k
[Clang][objectsize] Generate object size calculation for sub-objects #86858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bwendling
wants to merge
16
commits into
llvm:main
Choose a base branch
from
bwendling:__bdos-subobject
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
31af119
[Clang][objectsize] Generate object size calculation for sub-objects
bwendling 81b5a84
Make sure the field Decl we're looking as is the actual FAM before re…
bwendling 3a59a35
Make sure we're looking at the very last field in the struct, even if…
bwendling 0b66243
Follow the flexible array member through a pointer.
bwendling d2c4328
Don't calculate from the last index to the end of the entire N-diment…
bwendling a3362e8
Merge branch 'llvm:main' into __bdos-subobject
bwendling 206b305
Remove aggressive 'dereference' from the visitor, and simplify 'getLa…
bwendling 98d4823
Restrict 'VisitCastExpr' to no-op casts. Use 'IgnoreParenImpCasts' in…
bwendling 75e9037
Merge branch 'llvm:main' into __bdos-subobject
bwendling ed1604b
WIP
bwendling aa0406d
Merge branch 'llvm:main' into __bdos-subobject
bwendling 82bb459
The array base may not be an array itself.
bwendling 5168824
Fix testcases.
bwendling e38caf9
Simplify the cast visitor.
bwendling da1fd97
Add testcase.
bwendling b4dc683
Use IgnoreParens instead of IgnoreParenImpCasts. It's safer when we'r…
bwendling File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check whether ArrayIdx has side-effects? (If EmittedE is non-null, we don't check for side-effects otherwise.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do that on line 1156.