Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorchToLinalg] Implement lowering of torch.aten.rrelu_with_noise and torch.aten.rrelu_with_noise_backward ops (fix) #3748

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

bosko-syrmia
Copy link
Contributor

As title. @vivekkhandelwal1 This PR finalizes and resolves issues from #3645. Updated xfail_set and cherry-picked previous implementation.

Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change, and the rest looks good.

Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivekkhandelwal1 vivekkhandelwal1 merged commit 54d9e24 into llvm:main Oct 25, 2024
3 checks passed
@zjgarvey
Copy link
Collaborator

Hey @vivekkhandelwal1 this seems to be the commit that caused the CI to break on nightly.

@bosko-syrmia
Copy link
Contributor Author

It seems that some tests started failing on later nightly builds, after I committed last changes. So I made this PR #3835 that addresses those issues.

rahuls-cerebras added a commit that referenced this pull request Dec 31, 2024
…oise and torch.aten.rrelu_with_noise_backward ops (fix) (#3748)"

This reverts commit 54d9e24.
rahuls-cerebras added a commit that referenced this pull request Jan 2, 2025
…oise and torch.aten.rrelu_with_noise_backward ops (fix) (#3748)"

This reverts commit 54d9e24.
rahuls-cerebras added a commit that referenced this pull request Jan 2, 2025
…oise and torch.aten.rrelu_with_noise_backward ops (fix) (#3748)"

This reverts commit 54d9e24.
rahuls-cerebras added a commit that referenced this pull request Jan 2, 2025
…oise and torch.aten.rrelu_with_noise_backward ops (fix) (#3748)"

This reverts commit 54d9e24.
rahuls-cerebras added a commit that referenced this pull request Jan 3, 2025
…oise and torch.aten.rrelu_with_noise_backward ops (fix) (#3748)"

This reverts commit 54d9e24.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants