Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'simple media bulk upload' to core #726

Open
willguv opened this issue Jun 3, 2024 · 17 comments · May be fixed by #729
Open

Add 'simple media bulk upload' to core #726

willguv opened this issue Jun 3, 2024 · 17 comments · May be fixed by #729
Assignees

Comments

@willguv
Copy link
Member

willguv commented Jun 3, 2024

Some councils have installed https://www.drupal.org/project/simple_media_bulk_upload to speed up loading of multiple media files

@benhillsjones has used it in Haringey and rates it, was installed by Annertech

Let's install it on Prod and try it out

@willguv willguv converted this from a draft issue Jun 3, 2024
@willguv willguv assigned willguv and unassigned stephen-cox Jun 6, 2024
@willguv
Copy link
Member Author

willguv commented Jun 6, 2024

I'll try doing this with my new gitpod set up @stephen-cox

@willguv
Copy link
Member Author

willguv commented Jun 11, 2024

@stephen-cox with the help of @finnlewis I got this running and have taken it for a spin

Think it's very useful functionality and we should definitely include it as part of core, switched on

@willguv willguv changed the title Install 'simple media bulk upload' Add 'simple media bulk upload' to core Jun 11, 2024
@willguv willguv removed their assignment Jun 11, 2024
@markconroy markconroy self-assigned this Jun 11, 2024
@markconroy markconroy linked a pull request Jun 11, 2024 that will close this issue
@markconroy
Copy link
Member

@willguv I have a PR for this now #729

@willguv
Copy link
Member Author

willguv commented Jun 11, 2024

Wow! Thank you @markconroy

@willguv willguv moved this from Ready to In Progress - Core team in 2025 backlog Jun 11, 2024
@willguv willguv moved this from In Progress - Core team to Review in 2025 backlog Jun 25, 2024
@willguv willguv moved this from Review to In Progress - Everyone else in 2025 backlog Jul 24, 2024
@willguv
Copy link
Member Author

willguv commented Dec 18, 2024

Hi @markconroy what's the latest on your PR please?

@markconroy
Copy link
Member

@willguv it got discussed at Merge Tuesday last week. We're a little closer to a decision, but not fully there yet.

#729 (comment)

@willguv
Copy link
Member Author

willguv commented Jan 22, 2025

Any more news on this @markconroy? Thanks

@markconroy
Copy link
Member

markconroy commented Jan 22, 2025

I don't think it's been discussed any more. Everyone agrees with doing this, but there is disagreement on "how we do it".

I've kind of dropped out of that conversation as it's going in a direction I don't fully understand.

#729 (comment)

Discussing in Merge Tuesday:

@stephen-cox leaning towards composer-merge plugin rather than the npm asset packagist

@Adnan-cds is suggesting the approach here, but changing it a little to avoid specifying the dist and version, rather targeting the git repo and allow us to require a more open constraint.

Note: we really want to align on a preferred solution for LocalGov Drupal in general.

@stephen-cox points out that if we do require the libraries in the project composer.json, end users can decide whether to override this approach or not. So for us, we define our libraries in the localgov_project composer.json and remove the specific library definition here.

@willguv
Copy link
Member Author

willguv commented Jan 24, 2025

Here's how Wirral did this @markconroy @finnlewis

Media Bulk Upload Module Install
Modules used:

  1. Installed DropzoneJS module following the instructions on the Drupal page.
  2. Installed Media Bulk Upload module through composer the ‘usual way.’
  3. In the bulk upload configuration admin/config/media/media-bulk-config, created an
    upload profile for the types of media to be uploaded.
    Specific to Wirral site
  4. Set an INGRESSCOOKIE on the server to prevent files not uploading errors, as
    multiple running instances of the site caused issues when transferring from the
    temp:// folder.

@markconroy
Copy link
Member

@willguv That's exactly how my original PR for this added the module as well, but the conversation moved to adding the DropzoneJS library via a different method, and that's where we are at the moment.

  1. Figure out how to get DropzoneJS into the project (in a way that allows sites to use a different version if they wish)
  2. Add media bulk upload

@willguv
Copy link
Member Author

willguv commented Jan 28, 2025

Thanks Mark. I'm at MT today so will raise this - hope to see you there

@andybroomfield
Copy link
Contributor

We discussed the issue on MT on 28/1/2025.
We think a new module to handle this feature is the best way forward. We feel that rolling out to all sites may cause issues, particularly if they already have simple bulk upload media or a version of drop zone. By adding a new module that the profile / project downloads, that should alleviate the issue.

@willguv
Copy link
Member Author

willguv commented Jan 28, 2025

@finnlewis I'm wondering whether we'll have this challenge with the Refresh mission - we'll likely be proposing fundamental changes to some features and need to think about how to provide them to new users, and a choice for existing users.

@rupertj mentioned a "here's what you missed" idea where content designers can see the effect of upgrades before committing to them. I'm not sure how this would work, but would be very nice to have!

@willguv
Copy link
Member Author

willguv commented Jan 30, 2025

@stephen-cox @markconroy @andybroomfield please decide on the best way forward with this at today's Tech meet - thanks

@willguv willguv moved this from In Progress - Everyone else to In Progress - Core team in 2025 backlog Jan 30, 2025
@andybroomfield
Copy link
Contributor

@andybroomfield
Copy link
Contributor

andybroomfield commented Feb 5, 2025

Adding comment here for visibility.
See localgovdrupal/localgov_assets#2
It does not look like we can add repositories in dependencies.

  • ❌ adding via localgov_assets
  • ❌ adding via localgov (original PR)
  • ✅ adding via npm-asset (asset packagist)
  • ✅ adding via composer merge (with caveats)

@willguv willguv moved this from In Progress - Core team to Done in 2025 backlog Feb 11, 2025
@stephen-cox
Copy link
Member

I propose we go with @andybroomfield Composer Merge Plugin (PR localgovdrupal/localgov_project#173) and then merge @markconroy's PR in the profile #729 with the repositories section removed.

The release notes that include #729 would need to make it clear that existing sites will either need to use the Composer Merge Plugin or Asset Packagist to include the required Dropzone JS library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants