-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.gitignore shouldn't ignore composer.lock #186
Comments
We want to be careful though that those developing on this repo doesn't commit composer.lock. |
True, but making commits to this repo is something that's going to happen much less than people starting a project with this repo as a template. Also, people making commits to this repo -- more specifically, people merging PRs to this repo -- are going to be more knowledgeable about what to do than people starting a project with it. Composer's official documentation doesn't have much on project templates unfortunately! |
Historical discussion is on #8 Just checking and drupal recommend project does have a composer.lock file (but not a .gitignore) |
Might be overkill, but we could add a Composer script that removes those lines when |
The problem here is that after a developer uses this template to create a project, they can't commit the composer.lock file -- which is now part of their project -- until they change this.
The text was updated successfully, but these errors were encountered: