Skip to content

Fix PascalCase rule against words with diacritics marks #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ccoVeille opened this issue Apr 3, 2025 · 0 comments · May be fixed by #294
Open

Fix PascalCase rule against words with diacritics marks #293

ccoVeille opened this issue Apr 3, 2025 · 0 comments · May be fixed by #294

Comments

@ccoVeille
Copy link

The current implementation has issues

It iterates on runes, but then use the index of the rule in the list to get the previous character in the string and then convert it into a rune, which is invalid.

The issue appears while I worked on adding tests for diacritics #292
@ccoVeille ccoVeille linked a pull request Apr 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix pascal case behavior with diacritics marks ccoveille-forks/ls-lint-loeffel-io
1 participant
@ccoVeille