Add secret annotations' backward translation #23
Conversation
philimonoff
changed the title
|
Closes #22. |
| physicalClient client.Client | ||
| } | ||
|
|
||
| func (s *secretSyncer) getCertVirtualName(certPhysicalName string) (string, error) { |
There was a problem hiding this comment.
I'm not sure, but I think this function and function below could be transformed to single function getObjectVirtualName or something like that.
There was a problem hiding this comment.
when Oleg is back from holiday he may have thoughts, but for me this seems fine as two simple little functions like this!
There was a problem hiding this comment.
👋 hey there! im not super up to speed with the cert-manager plugin but just made a few nit picky comments here. I suspect we'll want to wait for Fabian or Oleg to chime back in after the holidays before getting merged since they've got more context... but, seems reasonable to me from what I know :)
| physicalClient client.Client | ||
| } | ||
|
|
||
| func (s *secretSyncer) getCertVirtualName(certPhysicalName string) (string, error) { |
There was a problem hiding this comment.
when Oleg is back from holiday he may have thoughts, but for me this seems fine as two simple little functions like this!
|
@carlmontanari Hi! |
|
nice, thanks for the little clean up! I think you'll be waiting till the new year what w/ holidays/time off and such. |
2 participants
No description provided.