From ee2c36bc29de31ffecc771386c96179d066178d2 Mon Sep 17 00:00:00 2001
From: David Rusu <davidrusu.me@gmail.com>
Date: Sun, 1 Dec 2024 23:12:26 +0400
Subject: [PATCH] cryptarchia: remove debug log

---
 cryptarchia/cryptarchia.py | 40 +++++++++++---------------------------
 1 file changed, 11 insertions(+), 29 deletions(-)

diff --git a/cryptarchia/cryptarchia.py b/cryptarchia/cryptarchia.py
index 8404e42..b510962 100644
--- a/cryptarchia/cryptarchia.py
+++ b/cryptarchia/cryptarchia.py
@@ -195,13 +195,7 @@ def new(coin: Coin, slot: Slot, parent: Id):
 
     def verify(self, slot: Slot, parent: Id):
         # TODO: verification not implemented
-        if slot != self.slot:
-            logger.warning("PoL: wrong slot")
-            return False
-        if parent != self.parent:
-            logger.warning("PoL: wrong parent")
-            return False
-        return True
+        return slot == self.slot and parent == self.parent
 
 
 @dataclass
@@ -213,12 +207,6 @@ class BlockHeader:
     leader_proof: MockLeaderProof
     orphaned_proofs: List["BlockHeader"] = field(default_factory=list)
 
-    def __post_init__(self):
-        assert type(self.slot) == Slot
-        assert type(self.parent) == Id
-        assert self.slot == self.leader_proof.slot
-        assert self.parent == self.leader_proof.parent
-
     def update_header_hash(self, h):
         # version byte
         h.update(b"\x01")
@@ -388,7 +376,8 @@ def validate_header(self, block: BlockHeader) -> bool:
 
         current_state = self.ledger_state[block.parent].copy()
 
-        # we use the proposed block epoch state to validate orphans as well
+        # We use the proposed block epoch state to validate orphans as well.
+        # For very old orphans, these states may be different.
         epoch_state = self.compute_epoch_state(
             block.slot.epoch(self.config), block.parent
         )
@@ -443,21 +432,14 @@ def verify_slot_leader(
         # This will change once we start putting merkle roots in headers
         current_state: LedgerState,
     ) -> bool:
-        if not proof.verify(slot, parent):
-            logger.warning("invalid PoL")
-            return False
-        if not (
-            current_state.verify_eligible_to_lead(proof.commitment)
-            or epoch_state.verify_eligible_to_lead_due_to_age(proof.commitment)
-        ):
-            logger.warning("invalid commitment")
-            return False
-
-        if not current_state.verify_unspent(proof.nullifier):
-            logger.warning("PoL coin already spent")
-            return False
-
-        return True
+        return (
+            proof.verify(slot, parent)  # verify slot leader proof
+            and (
+                current_state.verify_eligible_to_lead(proof.commitment)
+                or epoch_state.verify_eligible_to_lead_due_to_age(proof.commitment)
+            )
+            and current_state.verify_unspent(proof.nullifier)
+        )
 
     def on_block(self, block: BlockHeader):
         if block.id() in self.ledger_state: