Esm wrap #156
Merged
Esm wrap #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Furthermore, there is no breaking change. So no major release is required. Existing pta version will work with next zora version. |
lorenzofox3
reviewed
Jun 24, 2022
--module-loader arg is now ignored, existing command line with that arg will still work.
|
BTW, suggest to add more supported Nodejs versions to the CI setup. |
|
Great thanks |
|
Any pta release? |
|
you can't just |
|
Pta has code change that removed module loader. |
|
🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zora now only ships cjs dist. Use esm wrapper to reuse cjs instance in Nodejs environment.--module-loaderfrom pta, but kept it in the arg schema to avoid breaking user's existing command line.As a result, cjs and es test code can now be reported together by zora.
closes #155, #118