-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zora pta doesn't report anything if there are any pending tests that don't wait for any events #162
Comments
Its the opposire of late assertion. Create a test that returns |
Oh I see. Thanks. I'am getting a look at it |
Apparently, finding a broken promise is quite a thing The only easy way I can think of (which would be cross platform) is to make the user spec function compete with a timeout function and throw if the timeout wins. something like this PR |
Here's what I'd do:
|
Actually that's not that simple. There is only an exit hook in a nodejs environment (and Deno) but not in the browser. You can't either add this check after the reporting stream as it is simply broken (the code after won't run). I think I'll rather go for test timeout which adds anyway a nice to have assertion |
I don't have a minimal zora repro but it's obvious from this:
run
node x.mjs
and you won't see hello but the program will terminate successfully. In the case of zora, you will see the program terminate but it won't report anything. Ideally (a 10 star experience) the test runner would execute normally and report and then it would tell me "hey, this and this test is still pending but it's not waiting for anything. It's most likely a bug".The text was updated successfully, but these errors were encountered: