-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dezoomify-rs Color Distortion #259
Comments
I have checked and you can see the difference that I'm talking about in browser by open all images link and switching through them. Very noticeable with the first image, to see it between 2 and 3 focus on the lady's hair and you will see the green shade. |
How to compare them if they are different in size/color? JPEG 4576×6000, 24 bits What's in the original? Either one image (jpg) is expanded to a higher resolution and color (adding what is not in the original; we are not discussing the losses/artifacts caused by jpeg compression itself, but they are also present), or another image (png) is reduced to a lower resolution and color (losing what is in the original). Ok, let's assume that the resolution was lowered when the png files were uploaded to Github. Look at the parameters of the images in your PC copy, whether they have different numbers of colors or not (8, 24, 32 bits). I believe the original image is 4576×6000, 24 bits. Try this command for jpeg: |
Hi, |
Got it! Try dezoomify-rs.exe version 2.12.1 (not newer). Version 2.12.1 (and older) works differently (at least I can see that the colors are different from what I get in newer versions). Version 2.12.2 gives an error “ERROR Input/Output error: The encoder or decoder for Jpeg does not support the color type Version 2.12.3 gives me “your” greenish “distorted” colors. The developer (@lovasoa) seems to have solved the bug in the previous version. Maybe this is the reason for what is happening with colors? I really don't know. Version 2.12.4 doesn't seem to work on my current PC with Windows 7, so I can't test it right now (need the bcryptprimitives.dll library and other related libraries). P.S. You'll find all the versions of dezoomify-rs here |
Oh, it looks like you are reporting a regression ! I'll have to look into this. But I don't see the difference between the three images above to the naked eye. |
It was almost impossible for me to see the difference, too. This greenness is so elusive and seems natural! In order not to depend on different formats and sizes, I did not use the pictures provided by @IGUPAYITI, but downloaded them myself with different versions of dezoomify-rs, and then opened both. When switching from one to the other image, I immediately saw that subtle difference and that greenish. Here, look at the light colors on the chest, can you see the slight difference? |
Wow @Cosmicore, amazing work! |
I just noticed that @lovasoa promptly released the new version 2.12.5 yesterday. Thanks a lot, @lovasoa ! @IGUPAYITI, have you tested it yet? I'm very interested in what you would say, is your problem (issue) solved? I'm on a Windows 7/64 machine again now, and here the new version doesn't start at all, it immediately crashes with the error “The application was unable to start correctly (0xc0000005)”. So I can't test it right now and report the results. |
Hello, I tested it now, the "green" was still there! |
Try hue-tint correction/normalisation. |
I reported the issue upstream here: image-rs/image#2333 |
v2.13 downgrades image-rs to v0.24 and should fix the issue |
Hello, when downloading through dezoomify-rs images have a very noticeable green shade if saved as jpg and a mild one if saved as png/tif, regardless of compression. There is no problem if the image is downloaded with the browser but it is very slow and with the site I can't download very large image at full resolution. If you can download the images and view them, switching from one to one, it is very noticeable (I'm using Photoshop), particularly between jpg-rs and png-web (you need to pay attention to see it between png-rs and png-web but it is there).
How can I solve this problem? Thank you.
Images for reference:
The text was updated successfully, but these errors were encountered: