coding

Author: kevzoid

lib/chrome.js

@@ -56,7 +56,7 @@ class Chrome extends EventEmitter {
         this.useHostName = !!(options.useHostName);
         this.alterPath = options.alterPath || ((path) => path);
         this.protocol = options.protocol;
-        this.local = !!(options.local || options.process);
+        this.local = !!(options.local);
         this.target = options.target || defaultTarget;
         this.connectOptions = options.connectOptions;
         this.process = options.process;
@@ -121,11 +121,10 @@ class Chrome extends EventEmitter {
         try {
             if (this.process)
             {
-                const options = {local: this.local, cdp: this};
                 // we first "connect" to stdio pipes, so that we can
                 // first the protocol remotely via the pipe.
                 await this._connect();
-                const protocol = await this._fetchProtocol(options);
+                const protocol = await this._fetchProtocol({});
                 api.prepare(this, protocol);
             }
             else
@@ -139,7 +138,7 @@ class Chrome extends EventEmitter {
                     ...this.connectOptions,
                 };
                 // fetch the WebSocket debugger URL
-                const url = await this._fetchDebuggerURL(options);
+                const url = await this._fetchWsDebuggerURL(options);
                 // allow the user to alter the URL
                 const urlObject = parseUrl(url);
                 urlObject.pathname = options.alterPath(urlObject.pathname);
@@ -166,7 +165,7 @@ class Chrome extends EventEmitter {
     }
 
     // fetch the WebSocket URL according to 'target'
-    async _fetchDebuggerURL(options) {
+    async _fetchWsDebuggerURL(options) {
         const userTarget = this.target;
         switch (typeof userTarget) {
         case 'string': {
@@ -211,6 +210,8 @@ class Chrome extends EventEmitter {
         // otherwise user either the local or the remote version
         else {
             options.local = this.local;
+            if (this.process)
+                options.cdp = this;
             return await devtools.Protocol(options);
         }
     }

lib/devtools.js

@@ -53,7 +53,7 @@ function Protocol(options, callback) {
     {
         return options.cdp.send('Browser.getProtocolJson')
             .then(data=>callback(null, JSON.parse(data.result)))
-            .catch(callback)
+            .catch(callback);
     }
     // if the local protocol is requested
     if (options.local) {