Skip to content

Commit 9a74795

Browse files
authored
Merge pull request #4 from luozhouyang/revert-3-zero-division-solution
Revert "added regex prior to profiles calculation"
2 parents c634045 + 22feb94 commit 9a74795

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

similarity/cosine.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@
2424
from .string_distance import NormalizedStringDistance
2525
from .string_similarity import NormalizedStringSimilarity
2626

27-
import re
28-
_SPACE_PATTERN = re.compile("\\s+")
29-
3027

3128
class Cosine(ShingleBased, NormalizedStringDistance,
3229
NormalizedStringSimilarity):
@@ -44,10 +41,6 @@ def similarity(self, s0, s1):
4441
raise TypeError("Argument s1 is NoneType.")
4542
if s0 == s1:
4643
return 1.0
47-
48-
s0 = _SPACE_PATTERN.sub("", s0)
49-
s1 = _SPACE_PATTERN.sub("", s1)
50-
5144
if len(s0) < self.get_k() or len(s1) < self.get_k():
5245
return 0.0
5346
profile0 = self.get_profile(s0)

similarity/jaccard.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
from .string_distance import NormalizedStringDistance, MetricStringDistance
2323
from .string_similarity import NormalizedStringSimilarity
2424

25-
import re
26-
_SPACE_PATTERN = re.compile("\\s+")
2725

2826
class Jaccard(ShingleBased, MetricStringDistance, NormalizedStringDistance, NormalizedStringSimilarity):
2927

@@ -40,10 +38,6 @@ def similarity(self, s0, s1):
4038
raise TypeError("Argument s1 is NoneType.")
4139
if s0 == s1:
4240
return 1.0
43-
44-
s0 = _SPACE_PATTERN.sub("", s0)
45-
s1 = _SPACE_PATTERN.sub("", s1)
46-
4741
if len(s0) < self.get_k() or len(s1) < self.get_k():
4842
return 0.0
4943
profile0 = self.get_profile(s0)

0 commit comments

Comments
 (0)