movve array access interface implementation into a separate class

Author: m-bymike

src/AccessibleArray.php

@@ -0,0 +1,89 @@
+<?php
+/**
+ * ----------------------------------------------------------------------------
+ * This code is part of the Sclable Business Application Development Platform
+ * and is subject to the provisions of your License Agreement with
+ * Sclable Business Solutions GmbH.
+ *
+ * @copyright (c) 2016 Sclable Business Solutions GmbH
+ * ----------------------------------------------------------------------------
+ */
+
+namespace sclable\arrayFunctions;
+
+/**
+ * Class AccessibleArray
+ *
+ *
+ * @package sclable\arrayFunctions
+ * @author Michael Rutz <[email protected]>
+ *
+ */
+class AccessibleArray implements \ArrayAccess
+{
+    /**
+     * the raw array data container
+     * @var array
+     */
+    protected $data;
+
+
+    /**
+     * ArrayWrap constructor.
+     * @param array $data
+     */
+    public function __construct($data)
+    {
+        if (is_array($data) !== true) {
+            throw new \InvalidArgumentException('The first argument $data is not an array.');
+        }
+
+        $this->data = $data;
+    }
+
+    /**
+     * Whether a offset exists
+     * @link http://php.net/manual/en/arrayaccess.offsetexists.php
+     * @param mixed $offset An offset to check for.
+     * @return boolean true on success or false on failure.
+     * The return value will be casted to boolean if non-boolean was returned.
+     */
+    public function offsetExists($offset)
+    {
+        return array_key_exists($offset, $this->data);
+    }
+
+    /**
+     * Offset to retrieve
+     * @link http://php.net/manual/en/arrayaccess.offsetget.php
+     * @param mixed $offset The offset to retrieve.
+     * @return mixed Can return all value types.
+     */
+    public function offsetGet($offset)
+    {
+        return array_key_exists($offset, $this->data) ? $this->data[$offset] : null;
+    }
+
+    /**
+     * Offset to set
+     * @link http://php.net/manual/en/arrayaccess.offsetset.php
+     * @param mixed $offset The offset to assign the value to.
+     * @param mixed $value The value to set.
+     * @return void
+     */
+    public function offsetSet($offset, $value)
+    {
+        $this->data[$offset] = $value;
+    }
+
+    /**
+     * Offset to unset
+     * @link http://php.net/manual/en/arrayaccess.offsetunset.php
+     * @param mixed $offset The offset to unset.
+     * @return void
+     */
+    public function offsetUnset($offset)
+    {
+        unset($this->data[$offset]);
+    }
+}

src/ArrayWrap.php

@@ -34,14 +34,8 @@
  * @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
  *
  */
-class ArrayWrap implements \ArrayAccess
+class ArrayWrap extends AccessibleArray
 {
-    /**
-     * the raw array data container
-     * @var array
-     */
-    private $data;
-
     /**
      * Factory method
      *
@@ -71,18 +65,7 @@ public static function range($start, $end)
         return static::create(range($start, $end));
     }
 
-    /**
-     * ArrayWrap constructor.
-     * @param array $data
-     */
-    public function __construct($data)
-    {
-        if (is_array($data) !== true) {
-            throw new \InvalidArgumentException('The first argument $data is not an array.');
-        }
 
-        $this->data = $data;
-    }
 
     /**
      * return the raw data array
@@ -104,53 +87,6 @@ protected function reply(array $data)
         return static::create($data);
     }
 
-    /**
-     * Whether a offset exists
-     * @link http://php.net/manual/en/arrayaccess.offsetexists.php
-     * @param mixed $offset An offset to check for.
-     * @return boolean true on success or false on failure.
-     * The return value will be casted to boolean if non-boolean was returned.
-     */
-    public function offsetExists($offset)
-    {
-        return $this->hasKey($offset);
-    }
-
-    /**
-     * Offset to retrieve
-     * @link http://php.net/manual/en/arrayaccess.offsetget.php
-     * @param mixed $offset The offset to retrieve.
-     * @return mixed Can return all value types.
-     */
-    public function offsetGet($offset)
-    {
-        return $this->hasKey($offset) ? $this->data[$offset] : null;
-    }
-
-    /**
-     * Offset to set
-     * @link http://php.net/manual/en/arrayaccess.offsetset.php
-     * @param mixed $offset The offset to assign the value to.
-     * @param mixed $value The value to set.
-     * @return void
-     */
-    public function offsetSet($offset, $value)
-    {
-        $this->data[$offset] = $value;
-    }
-
-    /**
-     * Offset to unset
-     * @link http://php.net/manual/en/arrayaccess.offsetunset.php
-     * @param mixed $offset The offset to unset.
-     * @return void
-     */
-    public function offsetUnset($offset)
-    {
-        unset($this->data[$offset]);
-    }
-
-
     /**
      * Pad the array to the specified length with a value
      * @see array_pad()