Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the event of a network outage, e2e tests can be come synchronized #31

Open
nkinkade opened this issue May 8, 2020 · 0 comments
Open

Comments

@nkinkade
Copy link
Contributor

nkinkade commented May 8, 2020

There was a long-standing bug recently discovered in the ndt_e2e.sh test which was causing tests to run at more random intervals and likely more frequently than every 10 minutes.

Yesterday, @stephen-soltesz discovered this:

script_exporter_e2e_synchronization

After the event (around 08:00 UTC) there is a very clear 10m period. After investigation, discovered that for some reason the tests had become more synchronized that they were before. In the event of a test failure (perhaps due to a network outage) all tests will begin running every single minute until a success is registered. When the network finally comes back the tests will start succeeding, but by this time they are all running close to within one minute of each other. From there forward, they will be less spaced out. It turns out that the bug referenced above was probably protecting us from this sort of synchronization.

We need to figure out a more robust way of keeping tests spaced as uniformly across 10m as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants