Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traceroute-caller sometimes calls traceroute twice for a given connection #25

Open
pboothe opened this issue Oct 2, 2019 · 1 comment

Comments

@pboothe
Copy link
Contributor

pboothe commented Oct 2, 2019

The following Bigquery query discovers 300+ times traceroute-caller was called multiple times for a given UUID:

with 
uuids as (
  SELECT COUNT(*) as count, uuid, Parseinfo.TaskFileName as fname
  FROM `mlab-staging.batch.traceroute`
  group by uuid, Parseinfo.TaskFileName
)
select uuid, fname from uuids where count > 1 and uuid != ""

This seems pretty obviously incorrect, and we should fix it. Note that the UUID appearing multiple times here is in fact correct - it's the same connection (and so the same UUID) causing multiple calls to scamper's traceroute system.

@yachang
Copy link
Contributor

yachang commented Oct 10, 2019

For 3 days:

SELECT

COUNT(DISTINCT uuid) AS num

FROM (

SELECT uuid

FROM mlab-staging.batch.traceroute

WHERE
DATE(_PARTITIONTIME) BETWEEN DATE("2019-08-10") AND DATE("2019-08-12")
AND uuid != ""
)

return 1353774

SELECT

COUNT(uuid) AS num

FROM (

SELECT uuid

FROM mlab-staging.batch.traceroute

WHERE
DATE(_PARTITIONTIME) BETWEEN DATE("2019-08-10") AND DATE("2019-08-12")
AND uuid != ""
)

return 1353800

The difference is 26 for 3 days, small enough to lower the priority to P2.

@yachang yachang added P2 and removed P0 labels Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants