Why is BaseResourceService::addRelationsToExistingModel defined if it is not used?

[ghost]

Hi,
I was going through the lib files and noticed that this function is not used anywhere. Why?

laravel-crud-wizard-free/src/Services/BaseResourceService.php

Line 195 in 1d3a509

protected function addRelationsToExistingModel(array $withRelations, BaseModel $model): void

[macropay-solutions]

Hi and welcome.
If you look at the get function

laravel-crud-wizard-free/src/Services/BaseResourceService.php

Line 41 in 1d3a509

return $this->model::query()->with($withRelations)->where(

you will see we are using with.

The eager loading in laravel and lumen had and still has some bugs as you saw in the issues from laravel github laravel/framework#51825.
The get can be easily overwritten to not use with but use this unused by default function, that will avoid the eager loading.

[macropay-solutions]

We added a fix for the above issue laravel/framework#51825 (comment)