Skip to content

Question on how are this coding standards used in the Quality Reports of Adobe Commerce Marketplace #481

@madalinignisca

Description

@madalinignisca

Description

This is more of a question. I found this repository through the link to a Magento extension for passed Coding Standards.

My particular concern is the filesystem. I looked over the https://github.com/magento/magento-coding-standard/tree/develop/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php, and it made me think that it only warns about any of those functions.

Is the Magento Marketplace rejecting extensions that use direct filesystem functions, making them incompatible with remote storage? We did face this kind of extension when buying directly from vendors not listed on the Marketplace, and we'd like to know how much to trust the Marketplace for all the Quality Reports.

Expected behaviour

Any listed extension in the Marketplace with a passed Coding Standard would not have any warnings and work 100% with remote storage.

Benefits

All extensions would be remote storage compatible.

Additional information

Trust that these tests are enforced for Adobe Commerce Marketplace and don't allow warnings.

Activity

m2-assistant

m2-assistant commented on Jul 2, 2024

@m2-assistant

Hi @madalinignisca. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

moved this to Ready for Grooming in Backlogon Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Ready for Grooming

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @madalinignisca

        Issue actions

          Question on how are this coding standards used in the Quality Reports of Adobe Commerce Marketplace · Issue #481 · magento/magento-coding-standard