Skip to content

PHP 8.3 error mentioning php 8.1 as version #484

@MaximGns

Description

@MaximGns

Preconditions

1.magento/product-enterprise-edition: "2.4.7-p1"
2. magento/magento-coding-standard: "33"
3. Previous coding standard version --> 31

PHP 8.3.9 (cli) (built: Jul  2 2024 14:10:14) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.9, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.9, Copyright (c), by Zend Technologies
FILE: ...ta/******.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 9 | ERROR | Readonly classes are not supported in PHP 8.1 or earlier.
   |       | (PHPCompatibility.Classes.NewReadonlyClasses.Found)
--------------------------------------------------------------------------------

Activity

m2-assistant

m2-assistant commented on Aug 5, 2024

@m2-assistant

Hi @MaximGns. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

MaximGns

MaximGns commented on Aug 7, 2024

@MaximGns
Author

@fredden How to resolve this issue when using GrumPHP?

fredden

fredden commented on Aug 7, 2024

@fredden
Member

@MaximGns There are instructions on the PHPCompatibility repository for how to set testVersion via command line and/or in a custom ruleset. I've not tested with two custom rulesets both setting the value to see what comes out. You should be able to run phpcs --standard=Magento2 --runtime-set testVersion 8.3 ... to tell PHPCompatibility that you want to validate your code against PHP version 8.3 instead of the version(s) listed within the Magento2 ruleset.

MaximGns

MaximGns commented on Aug 8, 2024

@MaximGns
Author

@fredden thanks for explenation, but why not support 8.3 out of the box as magento itself also supports? why only php 8.1/8.2...

moved this to Ready for Grooming in Backlogon Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Ready for Grooming

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @fredden@MaximGns

      Issue actions

        PHP 8.3 error mentioning php 8.1 as version · Issue #484 · magento/magento-coding-standard