[Issue] Bug fix for .lib-button-reset() not resetting text color

[m2-assistant]

This issue is automatically created based on existing pull request: #34445: Bug fix for .lib-button-reset() not resetting text color

---

Description (*)

Fixed issue where .lib-button-reset() resets the background but not the color.

Corrects issue where button text color does not provide enough contrast on standard background color (i.e. dark buttons with white text reset may present a white text on a white background).

Manual testing scenarios (*)

1. Theme with the following variables set...

@primary__color: @color-black;
@page__background-color: @color-white;
@button__color: @color-white;
@button__background: @color-black;

2. On elements that use the .lib-button-reset() mixin such as the minicart "close" icon, it appears as a white "x" on a white background.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @schizek,

Thank you for the report and collaboration!

Verified this issue on 2.4-develop.
Created a custom theme with following variables

@primary__color: @color-black;
@page__background-color: @color-white;
@button__color: @color-white;
@button__background: @color-black;

We observed that button text color does not provide enough contrast on standard background color.

Please take a look at the screencast:

Screen.Recording.2024-03-01.at.2.42.24.PM.mov

Hence confirming the issue.

Thank you.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11477 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.