ElasticSearch connectivity issue resulting in cached empty category pages

[p24-max]

Preconditions and environment

• Magento version 2.4.6-p3
• Magento ElasticSearch7 / OpenSearch module
• Not working ElasticSearch (e.g. due to network failure)

Steps to reproduce

• Stop elasticsearch service
• Load category page, you will see "We can't find products matching the selection." message
• Recover elasticsearch (e.g. start elasticsearch / fix connectivity issue)
• Reload category page, it still shows the >>no products found<< message because the page is cached in FPC.

Expected result

In case of an elasticsearch exception, the page should not be cached in FPC so that once elasticsearch recovered, the products will get shown without manual need to flush the cache

Actual result

Category page is stored in FPC, regardless of elasticsearch availability

Additional information

Relevant code:

• magento2/app/code/Magento/OpenSearch/SearchAdapter/Adapter.php

  Lines 114 to 115 in 57cbaad

  	// return empty search result in case an exception is thrown from OpenSearch
  	$rawResponse = self::$emptyRawResponse;

• magento2/app/code/Magento/Elasticsearch7/SearchAdapter/Adapter.php

  Lines 117 to 118 in 57cbaad

  	// return empty search result in case an exception is thrown from Elasticsearch
  	$rawResponse = self::$emptyRawResponse;

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @p24-max. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[p24-max]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @p24-max. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @p24-max, here is your Magento Instance: https://f8436ea6193ca331f85f3f6c1f9b1aea.instances-prod.magento-community.engineering
Admin access: https://f8436ea6193ca331f85f3f6c1f9b1aea.instances-prod.magento-community.engineering/admin_1a46
Login: c7dc8b39
Password: 27ede50ec9c0

[p24-max]

I was able to reproduce it at @magento provided develop instance:

1. Change Elasticsearch port in admin to simulate connectivity issue (opensearch_server_port)
2. Open https://f8436ea6193ca331f85f3f6c1f9b1aea.instances-prod.magento-community.engineering/men/tops-men/jackets-men.html

3. Change port back to original value (to simulate recovery of elasticsearch connection)
4. Reloaded https://f8436ea6193ca331f85f3f6c1f9b1aea.instances-prod.magento-community.engineering/men/tops-men/jackets-men.html -> Still no products are shown (as its now stored in FPC)
   (When adding a cache busting query parameter, products are shown: https://f8436ea6193ca331f85f3f6c1f9b1aea.instances-prod.magento-community.engineering/men/tops-men/jackets-men.html?cache=buster)

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @p24-max,

Thanks for the report and collaboration!

We have tried to reproduce the issue by following the below steps:

1. Stop the OpenSearch service

2. Try to access a category from the front end. We are getting the below page:
   

3. After starting the OpenSearch service, we are getting the same error page.

4. The products can be visible only if clearing the cache.

Hence confirming the issue.

Thanks